From af4f200ee434808758428c06f3d8021010e60456 Mon Sep 17 00:00:00 2001 From: Andreas Dangel Date: Fri, 18 May 2012 15:00:08 +0200 Subject: [PATCH] Close the readers in a finally block (MPMD-145) --- .../org/apache/maven/plugin/pmd/PmdReportTest.java | 24 +++++++++++++++----- 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java b/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java index 3a97ffb..2bb227d 100644 --- a/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java +++ b/src/test/java/org/apache/maven/plugin/pmd/PmdReportTest.java @@ -20,6 +20,7 @@ package org.apache.maven.plugin.pmd; */ import org.codehaus.plexus.util.FileUtils; +import org.codehaus.plexus.util.IOUtil; import java.io.BufferedReader; import java.io.File; @@ -243,14 +244,25 @@ public class PmdReportTest { String strTmp; StringBuffer str = new StringBuffer( (int) file.length() ); - BufferedReader in = new BufferedReader( new FileReader( file ) ); - - while ( ( strTmp = in.readLine() ) != null ) + FileReader reader = null; + BufferedReader in = null; + try + { + reader = new FileReader( file ); + in = new BufferedReader( reader ); + + while ( ( strTmp = in.readLine() ) != null ) + { + str.append( ' ' ); + str.append( strTmp ); + } + in.close(); + } + finally { - str.append( ' ' ); - str.append( strTmp ); + IOUtil.close( in ); + IOUtil.close( reader ); } - in.close(); return str.toString(); } -- 1.7.10