17 throw custom exceptions. 16 throw custom exceptions. 15 throw custom exceptions. 14 throw custom exceptions. 44 clarify if the relation 1 zip file: 1 header + one data file is correct! 45 place a copy of the generated files in some backup-dir? 51 fill in lieferantenbez here!, Todo: inject as property" 125 maybe send to some dtag-server via (s)ftp... (must be done in finally-block!) 185 what excactly is auftrag??? how to handle? 115 the attribute sex is not set in the response; use for now null, but this has to be set somewhere 6 better rename to 'ControlEntryBufferDao' 13 Auto-generated method stub 67 this should be in ResultCode!!! 334 Implement forall properties p in (xpath://getResource(model.hbm.xml)/hibernate-mapping/class[@name="SubscriptionRow]/property this.setP( dtag.getP) note: perform calling of setters and getters with reflection or using ognl (http://www.ognl.org/) 57 implement and review!!! 58 Write unit tests!!! 64 if we fetch per s(ftp) files from dtag, implement this logic 85 --No comment-- 92 write to received header table in order to prevent duplicates? even better: add a row 'received' to table dtagheader in order to distinguish duplicated/outstanding data! In this case the received_header_daily table will become obsolete! Special handling is needed for replies of Nachbearbeitungsauftr㦥 (RN) 151 maybe copy to a 'processed' directory 188 wrap in try {...} catch {write control entry...} if you do not want a processing failure in the row cause a processing failure for the whole data-file... If you expect that no processing error occurrs (or really no error has to occur) leave it as it is. 200 Auto-generated method stub 206 Auto-generated method stub 213 Auto-generated method stub 219 Auto-generated method stub 229 try to decompose method!! 240 when exactly has viag13 to be set???????? (not always in plsql-proc!!!!) 255 deactivate record (check if this is all!!!) 259 make field persistent in row 270 check whether this is ok?! 311 --No comment-- 320 do not implement this hack but add logging printing more information about that strange situtation to help to analyze it and correct it at the right place 357 what is viag3?? why needed to rest o2.setViag3(null); 191 -> GP try to use hibernate stored procedures. (GP) 214 -> GP: try to use hibernate stored procedures. (GP) 15 add parmeter checking for setter (with LOG.warn) 16 comment getters/setters according to IF specs 17 and length check for string values accroding to DB schema! 301 ?maybe set to default 01090 iff r01==null 12 better rename to 'ControlEntryBuffer' 10 add hibernate implementation. See also comments in model.hbm.xml 45 maybe add field length restrictions here in fields where DTAGEntry data 78 set as spring injected property 80 set as spring injected property Note: provide a SpringConfigUtil Factory reading DB-Values from a DB table e.g.: <property msisdnPrefixes> <bean class="..DbSpringConfig" factory-method="readList()"> <constructor-arg value="SELECT TELNR FROM DSS.VORWAHL"/> </bean> </property> 180 move to Receiver 183 create a control entry (fileName, a02, "phone-numer" "not found in dss-db" SKIP that row! 186 map a03, a07 194 better set Returncode to B???? 202 maybe set some mark or introduce special return code in order to prevent status-processor to process this row!! 206 more sophisticated construction/mapping of return code detailed information is contained in rueckmeldung.getMeldungArray() extend db structure to be capable of having a 1:n mapping DTAGENTRY 1 <-----> 0..* DTAGERROR (DTAGENTRY.ID, ERROR.ID, ERROR.TEXT) The mapping of error code affects tables DSS.STATUS_RESULT_MAPPING and DSS_DECISION.RESULT_MAPPING at least log this information! 231 is lieferannteneigene_id set always in the dtag reply? or is at least lieferanteneingene_id_ref set? Up to my (GP) understanding, at least one has to be set. 271 ? setAnsetzkennzeichen (0,1,2) that determines order of name particles to.setAnsetzkennzeichen(arg0) 292 updated when IF-Spec is clarified 302 Nutzung.Inkognito? addNutzung(to, "Inkognito", from.???; 303 Nutzing.Kopierverbot? addNutzung(to, "Kopierverbot", from.???); 334 DTAG-IF: SchreiTeil???????? TODO: unterschied: Tel/Fax u. Fax&fon??? 461 ? setAnsetzkennzeichen (0,1,2) that determines order of name particles to.setAnsetzkennzeichen(arg0) 481 db snf code migration e19 482 Check in final if sepc whether Behoerde exists or not! 489 db and code-migration a06 36 --No comment-- 44 what is li.vorgaengerDatenbestand for the initial aenderungslieferung? 45 make sure there is a initialHeader in the db 52 ????? 66 ????? 201 implement, consider encoding defined in DtagUtil at org.sonar.plugins.api.maven.xml.XpathParser.parse(XpathParser.java:123) at org.sonar.plugins.api.maven.xml.XpathParser.parse(XpathParser.java:112) at org.sonar.plugins.api.maven.xml.XpathParser.parse(XpathParser.java:96) at org.sonar.plugins.taglist.TaglistViolationsXmlParser.populateTaglistViolation(TaglistViolationsXmlParser.java:55) at org.sonar.plugins.taglist.TaglistMavenCollector.collect(TaglistMavenCollector.java:53) at org.sonar.mojo.InternalMojo.executeCollectors(InternalMojo.java:295) at org.sonar.mojo.InternalMojo.processModules(InternalMojo.java:177) at org.sonar.mojo.InternalMojo.execute(InternalMojo.java:156) at org.apache.maven.plugin.DefaultPluginManager.executeMojo(DefaultPluginManager.java:451) at org.codehaus.mojo.sonar.Bootstraper.executeMojo(Bootstraper.java:82) ... 20 more Caused by: org.xml.sax.SAXParseException: Invalid byte 2 of 3-byte UTF-8 sequence. at org.apache.xerces.parsers.DOMParser.parse(Unknown Source) at org.apache.xerces.jaxp.DocumentBuilderImpl.parse(Unknown Source) at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:124) at org.sonar.plugins.api.maven.xml.XpathParser.parse(XpathParser.java:118) ... 29 more