Index: src/main/java/org/apache/maven/continuum/web/action/ProjectViewAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/ProjectViewAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/ProjectViewAction.java (working copy) @@ -49,9 +49,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get project informations (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't get project informations (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get project informations (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/DeleteNotifierAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/DeleteNotifierAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/DeleteNotifierAction.java (working copy) @@ -50,9 +50,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't delete notifier (id=" + notifierId + ") for project " + projectId + " : " + e.getMessage() ); + addActionMessage( "Can't delete notifier (id=" + notifierId + ") for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't delete notifier (id=" + notifierId + ") for project " + projectId, e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/EditScheduleAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/EditScheduleAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/EditScheduleAction.java (working copy) @@ -75,8 +75,11 @@ } catch ( ContinuumException e ) { - // TODO Auto-generated catch block - e.printStackTrace(); + addActionError( "Can't update schedule (id=" + name + ")" ); + + getLogger().error( "Can't update schedule (id=" + name + ")", e ); + + return ERROR; } return SUCCESS; } @@ -90,7 +93,11 @@ } catch ( ContinuumException e ) { - e.printStackTrace(); + addActionError( "Can't get schedule (id=" + name + ")" ); + + getLogger().error( "Can't get schedule (id=" + name + ")", e ); + + return ERROR; } active = schedule.isActive(); Index: src/main/java/org/apache/maven/continuum/web/action/AddScheduleAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/AddScheduleAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/AddScheduleAction.java (working copy) @@ -62,7 +62,11 @@ } catch ( ContinuumException e ) { - e.printStackTrace(); + addActionMessage( "Can't add Schedule: " + name ); + + getLogger().error( "Can't add Schedule: " + name, e ); + + return ERROR; } return SUCCESS; } Index: src/main/java/org/apache/maven/continuum/web/action/ConfigurationAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/ConfigurationAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/ConfigurationAction.java (working copy) @@ -94,8 +94,10 @@ } catch ( ConfigurationStoringException e ) { - addActionError( "Can't store configuration :" + e.getMessage() ); + addActionError( "Can't store configuration" ); + getLogger().error( "Can't store configuration", e ); + return INPUT; } Index: src/main/java/org/apache/maven/continuum/web/action/AbstractNotifierEditAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/AbstractNotifierEditAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/AbstractNotifierEditAction.java (working copy) @@ -86,10 +86,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't update notifier (id=" + notifierId + ") for project " + projectId + " : " - + e.getMessage() ); + addActionMessage( "Can't update notifier (id=" + notifierId + ") for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't update notifier (id=" + notifierId + ") for project " + projectId, e ); return ERROR; } @@ -110,10 +109,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get notifier informations (id=" + notifierId + ") for project " + projectId - + " : " + e.getMessage() ); + addActionMessage( "Can't get notifier informations (id=" + notifierId + ") for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't get notifier informations (id=" + notifierId + ") for project " + projectId, e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/WorkingCopyAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/WorkingCopyAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/WorkingCopyAction.java (working copy) @@ -89,9 +89,9 @@ } catch ( ContinuumException e ) { - addActionError( "Can't get file list for project (id=" + projectId + ") : " + e.getMessage() ); + addActionError( "Can't get file list for project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get file list for project (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/ProjectEditAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/ProjectEditAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/ProjectEditAction.java (working copy) @@ -61,9 +61,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get project informations (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't get project informations (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get project informations (id=" + projectId + ")", e ); return ERROR; } @@ -86,9 +86,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't update project (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't update project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't update project (id=" + projectId + ")", e ); return ERROR; } @@ -104,9 +104,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get project informations (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't get project informations (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get project informations (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/BuildResultsListAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/BuildResultsListAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/BuildResultsListAction.java (working copy) @@ -52,9 +52,9 @@ } catch ( ContinuumException e ) { - addActionError( "Can't get build results list for project (id=" + projectId + ") : " + e.getMessage() ); + addActionError( "Can't get build results list for project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get build results list for project (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionEditAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionEditAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/BuildDefinitionEditAction.java (working copy) @@ -106,10 +106,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't update build definition (id=" + buildDefinitionId + ") for project " + projectId - + " : " + e.getMessage() ); + addActionMessage( "Can't update build definition (id=" + buildDefinitionId + ") for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't update build definition (id=" + buildDefinitionId + ") for project " + projectId, e ); return ERROR; } @@ -128,9 +127,10 @@ catch ( ContinuumException e ) { addActionMessage( "Can't get build definition informations (id=" + buildDefinitionId + ") for project " - + projectId + " : " + e.getMessage() ); + + projectId ); - e.printStackTrace(); + getLogger().error( "Can't get build definition informations (id=" + buildDefinitionId + ") for project " + + projectId, e ); return ERROR; } @@ -153,9 +153,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get schedules list : " + e.getMessage() ); + addActionMessage( "Can't get schedules list" ); - e.printStackTrace(); + getLogger().error( "Can't get schedules list", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/AddBuildDefinitionAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/AddBuildDefinitionAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/AddBuildDefinitionAction.java (working copy) @@ -73,9 +73,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get project informations for project " + projectId + " : " + e.getMessage() ); + addActionMessage( "Can't get project informations for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't get project informations for project " + projectId, e ); return ERROR; } @@ -86,9 +86,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't get schedules list : " + e.getMessage() ); + addActionMessage( "Can't get schedules list" ); - e.printStackTrace(); + getLogger().error( "Can't get schedules list", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/BuildProjectAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/BuildProjectAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/BuildProjectAction.java (working copy) @@ -53,9 +53,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't build project (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't build project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't build project (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/DeleteProjectAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/DeleteProjectAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/DeleteProjectAction.java (working copy) @@ -48,9 +48,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't delete project (id=" + projectId + ") : " + e.getMessage() ); + addActionMessage( "Can't delete project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't delete project (id=" + projectId + ")", e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/DeleteBuildDefinitionAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/DeleteBuildDefinitionAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/DeleteBuildDefinitionAction.java (working copy) @@ -48,9 +48,9 @@ } catch ( ContinuumException e ) { - addActionMessage( "Can't delete build definition (id=" + buildDefinitionId + ") for project " + projectId + " : " + e.getMessage() ); + addActionMessage( "Can't delete build definition (id=" + buildDefinitionId + ") for project " + projectId ); - e.printStackTrace(); + getLogger().error( "Can't delete build definition (id=" + buildDefinitionId + ") for project " + projectId, e ); return ERROR; } Index: src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/ScheduleAction.java (working copy) @@ -48,7 +48,11 @@ } catch ( ContinuumException e ) { - e.printStackTrace(); + addActionMessage( "Can't get schedules" ); + + getLogger().error( "Can't get schedules", e ); + + return ERROR; } return SUCCESS; Index: src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/SummaryAction.java (working copy) @@ -131,7 +131,9 @@ } catch( Exception e ) { - e.printStackTrace(); + getLogger().error( "Unknown exception caught", e ); + + return ERROR; } return SUCCESS; Index: src/main/java/org/apache/maven/continuum/web/action/BuildResultAction.java =================================================================== --- src/main/java/org/apache/maven/continuum/web/action/BuildResultAction.java (revision 429253) +++ src/main/java/org/apache/maven/continuum/web/action/BuildResultAction.java (working copy) @@ -60,10 +60,9 @@ } catch ( ContinuumException e ) { - addActionError( "Can't get build result (id=" + buildId + ") for project (id=" + projectId + ") : " - + e.getMessage() ); + addActionError( "Can't get build result (id=" + buildId + ") for project (id=" + projectId + ")" ); - e.printStackTrace(); + getLogger().error( "Can't get build result (id=" + buildId + ") for project (id=" + projectId + ")", e ); return ERROR; }