GeoTools

Oracle canProcess(Map) shoudl be true iff oracle jars present

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 2.0-b2
  • Fix Version/s: 2.0.0, 2.1.M1
  • Component/s: jdbc-oracle plugin, main
  • Labels:
    None
  • Environment:
    GeoServer

Description

This bug is marked as Major because it "hits the screen" in GeoServer.
(It is not a showstopper as GeoServer has protected itself during loading)

GeoServer recently ran into a problem when the oracle DataStore recognized a Map provided to the canProcess function - even though the required oracle drivers were not in the classpath.

This allowed the GeoServer user to set up a DataStore that appeared to work correctly up until it was actually used.

oracle module bug:
The oracle DataStore canProcess(Map) method should return false if the required JDBC Driver is unavailable at runtime.

data module request:
It would be even better if the OracleDataStore did not appear in the list of available DataStores returned by DataStoreFinder.

Issue Links

is depended upon by

Task - A task that needs to be done. GEOS-149 Update docs to describe adding oracle datastore jar

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is duplicated by

Bug - A problem which impairs or prevents the functions of the product. GEOS-65 Oracle cannot add FeatureTypes

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jody Garnett added a comment -
GEOT-89 describes OracleDataStore.canProcess( Map ) returning true even when the required JDBC Driver is not present.
Show
Jody Garnett added a comment - GEOT-89 describes OracleDataStore.canProcess( Map ) returning true even when the required JDBC Driver is not present.
Hide
Permalink
Sean Geoghegan added a comment -
I can alter canProcess, but removing Oracle from the list of available datasources returned by the DataStoreFinder would require changes to the data store interface.

I can address this next week since I am interstate for a demo at the moment.
Show
Sean Geoghegan added a comment - I can alter canProcess, but removing Oracle from the list of available datasources returned by the DataStoreFinder would require changes to the data store interface. I can address this next week since I am interstate for a demo at the moment.
Hide
Permalink
Richard Gould added a comment -
Hi yea Sean, we are putting off this bug in GeoServer since we have not heard from you. We will release our beta with out this fix, we would like to make a release by march 10th if that works out for you.
Show
Richard Gould added a comment - Hi yea Sean, we are putting off this bug in GeoServer since we have not heard from you. We will release our beta with out this fix, we would like to make a release by march 10th if that works out for you.
Hide
Permalink
Jody Garnett added a comment -
We could just remove the oracle datastore jar, it would prevent oracle from showing up in the list - meeting my ui requirements "if it does not work don't show it".

The instructions would then be modified to describe the installation of three jars for oracle (rather than the current two).
Show
Jody Garnett added a comment - We could just remove the oracle datastore jar, it would prevent oracle from showing up in the list - meeting my ui requirements "if it does not work don't show it". The instructions would then be modified to describe the installation of three jars for oracle (rather than the current two).
Hide
Permalink
Chris Holmes added a comment -
Hey, anyone have suggestions as to how to best implement this? I really want this done, as the alternative is to make a seperate download for oracle. People really didn't like our solution for the beta, mainly because it wasn't documented enough. I want rc1 out very soon, and it seems like more work for me to make an oracle download and explain the whole procedure of what will be much more of a bitch for users. It seems like it would be less work for me to just resolve this issue myself. So I'll play with it tomorrow, but suggestions as to how to go about it would be appreciated.
Show
Chris Holmes added a comment - Hey, anyone have suggestions as to how to best implement this? I really want this done, as the alternative is to make a seperate download for oracle. People really didn't like our solution for the beta, mainly because it wasn't documented enough. I want rc1 out very soon, and it seems like more work for me to make an oracle download and explain the whole procedure of what will be much more of a bitch for users. It seems like it would be less work for me to just resolve this issue myself. So I'll play with it tomorrow, but suggestions as to how to go about it would be appreciated.
Hide
Permalink
James Macgill added a comment -
is this now resolved / resolvable by the addition of isAvailable() to the DataStore api.
Show
James Macgill added a comment - is this now resolved / resolvable by the addition of isAvailable() to the DataStore api.
Hide
Permalink
Chris Holmes added a comment -
This was fixed awhile ago. Now I'd like to do something elegant form my new OCI oracle factory, but I can make another task for it.
Show
Chris Holmes added a comment - This was fixed awhile ago. Now I'd like to do something elegant form my new OCI oracle factory, but I can make another task for it.
Hide
Permalink
Anonymous added a comment -
http://www.mylosoft.com/ <a href="http://www.mylosoft.com/">world series portable poker table</a> thanks for your site
Show
Anonymous added a comment - http://www.mylosoft.com/ <a href=" http://www.mylosoft.com/ ">world series portable poker table</a> thanks for your site

People

  • Assignee:
    Unassigned
    Reporter:
    Jody Garnett
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: