Remove Rail / Array distinction

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: X10 2.0.1
  • Fix Version/s: X10 2.2
  • Component/s: Class Libraries
  • Labels:
    None

Description

The Rail class is essentially a restricted case (one-dimensional, zero-based, convex) of Array. Assuming we would also like immutable arrays (see XTENLANG-787), then ValRail is a restricted case of an immutable Array.

At the moment, code using {{Array(1){zeroBased}}} suffers a significant performance penalty compared to using Rail or ValRail. It would be nice if application programmers did not need to worry about this distinction, i.e. if Rail, ValRail were just high performance concrete implementations within the Array type hierarchy, created in the same way as other arrays.

Issue Links

is depended upon by

Task - A task that needs to be done. XTENLANG-962 Array library redesign

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

Major goal of 2.1.0 is to make this change, so marking it as critical.

Show
David Grove added a comment - Major goal of 2.1.0 is to make this change, so marking it as critical.
Hide
Permalink
David Grove added a comment -

Patch to compiler/runtime to interpret [a,b,c,...] as an Array literal instead of a ValRail literal.

Can't commit yet because some work needs to be done in the implementation of RectRegion first to avoid infinite regress....RectRegion to be changed to use an IndexedMemoryChunk[int] to hold the backing ints. not a ValRail (which in 2.1 will become an Array).

Show
David Grove added a comment - Patch to compiler/runtime to interpret [a,b,c,...] as an Array literal instead of a ValRail literal. Can't commit yet because some work needs to be done in the implementation of RectRegion first to avoid infinite regress....RectRegion to be changed to use an IndexedMemoryChunk[int] to hold the backing ints. not a ValRail (which in 2.1 will become an Array).
Hide
Permalink
David Grove added a comment -

bulk move of all unresolved issues from 2.1.1 to 2.1.2

Show
David Grove added a comment - bulk move of all unresolved issues from 2.1.1 to 2.1.2
Hide
Permalink
David Grove added a comment -

defer remaining 2.1.2 issues to 2.2.0

Show
David Grove added a comment - defer remaining 2.1.2 issues to 2.2.0
Hide
Permalink
David Grove added a comment -

r21145 changed Rail.x10 to

public type Rail[T] = Array[T]{self.rank==1,self.zeroBased,self.rect,self.rail};
Show
David Grove added a comment - r21145 changed Rail.x10 to 
public type Rail[T] = Array[T]{self.rank==1,self.zeroBased,self.rect,self.rail};
Hide
Permalink
David Grove added a comment -

bulk close of all 2.2.0 resolved issues.

Show
David Grove added a comment - bulk close of all 2.2.0 resolved issues.

People

  • Assignee:
    David Grove
    Reporter:
    Josh Milthorpe
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: