operators involving multi-dimensional region constants (e.g. [0..1,2..3] || [4..5,6..7]) don't (can't?) work

Details

Description

This might be a spec issue involving the rules for applying the library-specified $convert conversion from Rail[Region] to Region, or alternatively the mechanism by which [0..1,2..3] gets converted to a Region (e.g. maybe it should be hardwired, not an automatic conversion?)

// standin for Region
public class R {
    incomplete public static def $convert(rs: ValRail[R]): R;
    incomplete public def $or(r:R):R;
}

class Bug {

    // standin for val r:Region = [a..b, c..d]
    val r:R = [new R(), new R()];

    // this works as expected
    val w = r || r;

    // this works
    // standin for val z = r || [a..b, c..d]
    val x = r || [new R(), new R()];

    // this doesn't work
    // standin for val w = [a..b, c..d] || r
    val y = [new R(), new R()] || r;

    // this doesn't work
    // standin for val y = [a..b, c..d] || [a..b, c..d]
    val z = [new R(), new R()] || [new R(), new R()];
}

The || operator must have boolean
operands, not type x10.lang.ValRail[R]{self.length==2}.

Issue Links

is depended upon by

Task - A task that needs to be done. XTENLANG-962 Array library redesign

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Bruce Lucas added a comment -

Affects

RegionAlgebra
RegionBoundingBox
RegionDifference

Show
Bruce Lucas added a comment - Affects RegionAlgebra RegionBoundingBox RegionDifference
Hide
Permalink
Igor Peshansky added a comment - - edited

Defer to 1.7.5. This may be fixed in the refactoring of the frontend that will be committed later.

Show
Igor Peshansky added a comment - - edited Defer to 1.7.5. This may be fixed in the refactoring of the frontend that will be committed later.
Hide
Permalink
David Grove added a comment -

defer all open 1.7.5 issues to 1.9.1

Show
David Grove added a comment - defer all open 1.7.5 issues to 1.9.1
Hide
Permalink
David Grove added a comment -

Updated test case to 2.0 operator syntax and confirmed that doesn't work with r12227

// standin for Region
public class R {
    incomplete public static operator (rs: ValRail[R]): R;
    incomplete public operator this || (that:R):R;
}

class Bug {

    // standin for val r:Region = [a..b, c..d]
    val r:R! = [new R(), new R()];

    // this works as expected
    val w = r || r;

    // this works
    // standin for val z = r || [a..b, c..d]
    val x = r || [new R(), new R()];

    // this doesn't work
    // standin for val w = [a..b, c..d] || r
    val y = [new R(), new R()] || r;

    // this doesn't work
    // standin for val y = [a..b, c..d] || [a..b, c..d]
    val z = [new R(), new R()] || [new R(), new R()];
}
Show
David Grove added a comment - Updated test case to 2.0 operator syntax and confirmed that doesn't work with r12227 
// standin for Region
public class R {
    incomplete public static operator (rs: ValRail[R]): R;
    incomplete public operator this || (that:R):R;
}

class Bug {

    // standin for val r:Region = [a..b, c..d]
    val r:R! = [new R(), new R()];

    // this works as expected
    val w = r || r;

    // this works
    // standin for val z = r || [a..b, c..d]
    val x = r || [new R(), new R()];

    // this doesn't work
    // standin for val w = [a..b, c..d] || r
    val y = [new R(), new R()] || r;

    // this doesn't work
    // standin for val y = [a..b, c..d] || [a..b, c..d]
    val z = [new R(), new R()] || [new R(), new R()];
}
Hide
Permalink
David Grove added a comment -

Look at this as part of array library redesign.

Show
David Grove added a comment - Look at this as part of array library redesign.
Hide
Permalink
Igor Peshansky added a comment -

This is a language design and specification issue. Once we have the new operator lookup and coercion semantics, we can implement them in the frontend.

Show
Igor Peshansky added a comment - This is a language design and specification issue. Once we have the new operator lookup and coercion semantics, we can implement them in the frontend.
Hide
Permalink
Bard Bloom added a comment -

Deferred to 2.1.0

Show
Bard Bloom added a comment - Deferred to 2.1.0
Hide
Permalink
Vijay Saraswat added a comment -

The following 2.1 code works:

class A {

    val r  = new Array[Region(1){rect}][1..9, 1..9] as Region;
    

    // this works as expected
    val w = r && r;

    // this works
    val z = r && (new Array[Region(1){rect}][2..5, 2..5] as Region);
     

    // this doesn't work
    // standin for val w = [a..b, c..d] || r
    val y = (new Array[Region(1){rect}][2..5, 2..5] as Region) && r;

    // this doesn't work
    // standin for 
    val x = new Array[Region(1){rect}][1..9, 1..9] as Region && new Array[Region(1){rect}][1..9, 1..9] as Region;
    
    val a = 1..9;
    val r2 = a*a;
    val w2 = r2 && r2;
    val z2 = r2 && (2..5)*(2..5);
    val y2 =  (2..5)*(2..5) * r2;
    val x2 =  r2 && r2;
  
}
Show
Vijay Saraswat added a comment - The following 2.1 code works: 
class A {

    val r  = new Array[Region(1){rect}][1..9, 1..9] as Region;
    

    // this works as expected
    val w = r && r;

    // this works
    val z = r && (new Array[Region(1){rect}][2..5, 2..5] as Region);
     

    // this doesn't work
    // standin for val w = [a..b, c..d] || r
    val y = (new Array[Region(1){rect}][2..5, 2..5] as Region) && r;

    // this doesn't work
    // standin for 
    val x = new Array[Region(1){rect}][1..9, 1..9] as Region && new Array[Region(1){rect}][1..9, 1..9] as Region;
    
    val a = 1..9;
    val r2 = a*a;
    val w2 = r2 && r2;
    val z2 = r2 && (2..5)*(2..5);
    val y2 =  (2..5)*(2..5) * r2;
    val x2 =  r2 && r2;
  
}
Hide
Permalink
David Grove added a comment -

bulk close of 2.1.0 resolved issues.

Show
David Grove added a comment - bulk close of 2.1.0 resolved issues.

People

  • Assignee:
    Vijay Saraswat
    Reporter:
    Bruce Lucas
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: