X10

v.equals(v) returns false for x10 values

Details

  • Number of attachments :
    0

Description

 value V {}

public class Bug {
    public static def main(var args: Rail[String]): void = {
        val v = new V();
        x10.runtime.NativeRuntime.println(v.equals(v).toString());
    }
}

outputs false.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-309 C++ version of examples/Constructs/GC/RemoteRef.x10 fails with exception in Clock_c register_c

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dave Cunningham added a comment -

v == v checks the pointers, i.e. is broken since new V() != new V()

v.equals(v) is broken because value V does not have a ::equals method, thus inherits Value::equals which only returns true when given another concrete instance of Value

We should generate a .equals for every value that looks like this

bool equals (ref<Object> other) {
    if (other == this) return true;
    if (other->type != this->type) return false;  // see Value::equals for how to do this
    if (other->f1 != this->f1) return false;
    if (other->f2 != this->f2) return false;
    ...
    if (other->fn != this->fn) return false;
    return true;
}

Alternatively we can try and write a general equals() inside Value that uses memcmp, but that will mean new V() == new Value() and we will also have to memset to 0 on allocation to make sure all padding is 0

Show
Dave Cunningham added a comment - v == v checks the pointers, i.e. is broken since new V() != new V() v.equals(v) is broken because value V does not have a ::equals method, thus inherits Value::equals which only returns true when given another concrete instance of Value We should generate a .equals for every value that looks like this bool equals (ref< Object > other) { if (other == this ) return true ; if (other->type != this ->type) return false ; // see Value::equals for how to do this if (other->f1 != this ->f1) return false ; if (other->f2 != this ->f2) return false ; ... if (other->fn != this ->fn) return false ; return true ; } Alternatively we can try and write a general equals() inside Value that uses memcmp, but that will mean new V() == new Value() and we will also have to memset to 0 on allocation to make sure all padding is 0
Hide
Permalink
Igor Peshansky added a comment -

Now that we have a regression script, upgrading to Blocker.

Show
Igor Peshansky added a comment - Now that we have a regression script, upgrading to Blocker.
Hide
Permalink
Igor Peshansky added a comment -

This should now be fixed. However, I may have missed adding _struct_equals to some hand-written value class. Please verify.

Show
Igor Peshansky added a comment - This should now be fixed. However, I may have missed adding _struct_equals to some hand-written value class. Please verify.
Hide
Permalink
David Grove added a comment -

Bulk close of old resolved issues.

Show
David Grove added a comment - Bulk close of old resolved issues.

People

  • Assignee:
    Igor Peshansky
    Reporter:
    Olivier Tardieu
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: