X10

Java backend generates code that requires ecj as a post compiler

Details

  • Number of attachments :
    0

Description

Some of the Java code being generated won't compile with javac. We have a dependency on ecj as a post-compiler.

We must either remove the dependency by changing the code we generate or automate the use of ecj as a post compiler by having the ant scripts download the right version of ecj into x10.dist and then have the post-compile command invoke a script in x10.dist/bin that invokes the installed ecj instead of finding the platform javac.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

Marked as a blocker not because it is blocking me (I can use ecj), but because it blocks a 1.7.3 release. We don't have to fix this urgently, but can't release before it is addressed.

Show
David Grove added a comment - Marked as a blocker not because it is blocking me (I can use ecj), but because it blocks a 1.7.3 release. We don't have to fix this urgently, but can't release before it is addressed.
Hide
Permalink
David Grove added a comment -

Documented dependency, added build support to download ecj.jar, and modified x10c.in to invoke ecj as the postcompiler in r7300.

Show
David Grove added a comment - Documented dependency, added build support to download ecj.jar, and modified x10c.in to invoke ecj as the postcompiler in r7300.
Hide
Permalink
Bruce Lucas added a comment -

Apparently there are versions of javac that don't have this problem - any chance of prereqing such a version instead?

Show
Bruce Lucas added a comment - Apparently there are versions of javac that don't have this problem - any chance of prereqing such a version instead?
Hide
Permalink
David Grove added a comment -

I suppose we could if such a version of javac is actually available on all the platforms we want to support. It's a less robust solution since we can't as easily control which javac we find as we can by grabbing a specific ecj.jar which we know works.

Show
David Grove added a comment - I suppose we could if such a version of javac is actually available on all the platforms we want to support. It's a less robust solution since we can't as easily control which javac we find as we can by grabbing a specific ecj.jar which we know works.
Hide
Permalink
David Grove added a comment -

Sigh. Didn't realize that x10c++ execed x10c. Need to change the way I did the postcompile command. x10c++ is currently broken due to change in x10c.in. Will fix this today....

Show
David Grove added a comment - Sigh. Didn't realize that x10c++ execed x10c. Need to change the way I did the postcompile command. x10c++ is currently broken due to change in x10c.in. Will fix this today....
Hide
Permalink
David Grove added a comment -

added hack in r7304 to distinguish c++ vs. java backend in x10c.in

Show
David Grove added a comment - added hack in r7304 to distinguish c++ vs. java backend in x10c.in

People

  • Assignee:
    David Grove
    Reporter:
    David Grove
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: