Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Blocker
-
Resolution: Fixed
-
Affects Version/s: X10 1.7.2 - C++ hosted
-
Fix Version/s: X10 1.7.3
-
Component/s: Native X10: Compiler Codegen
-
Labels:None
-
Number of attachments :
Description
Performance of many things in the X10 library depends on inlining final methods. Currently this isn't happening in C++ back-end. The following need to be done:
1. Ensure (at least final) method bodies are in .h files. (This is currently the case for generics, which is also the case for which inlining peformance is most critical, so for an initial implementation nothing needs to be done for this requirement).
2. Declare the method bodies with the "inline" keyword.
3. Use non-virtual calls o->C::m for calls to final methods.
Activity
David Grove
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Fix Version/s | X10 1.7.2 - C++ hosted [ 14605 ] | |
| Fix Version/s | X10 1.7.2.1 [ 14695 ] |
David Grove
made changes -
| Assignee | Igor Peshansky [ ipeshansky ] | Dave Cunningham [ spark ] |
Dave Cunningham
made changes -
| Status | Open [ 1 ] | In Progress [ 3 ] |
Dave Cunningham
made changes -
| Status | In Progress [ 3 ] | Resolved [ 5 ] |
| Resolution | Fixed [ 1 ] |
Bruce Lucas
made changes -
| Status | Resolved [ 5 ] | Closed [ 6 ] |