X10

Nested async blocks handle variables incorrectly (AsyncInit2)

Details

  • Number of attachments :
    3

Description

The following test

public class FinishTest {
    public static def main(Array[String]) {
        var aaa : Int = 1;
        finish async {
            var bbb : Int = 2;
            finish async {
                aaa = bbb;
            }
        }
    }
}

fails compilation with Managed X10 compiler with the message

x10c: ----------
     1. ERROR in /share/bcp2/ey06149/X10/work/FinishTest.java (at line 281)
        $aaa43[0]=aaa;
         ^^^
     aaa cannot be resolved
     ----------
     2. ERROR in /share/bcp2/ey06149/X10/work/FinishTest.java (at line 308)
        aaa = ((int)$aaa43[0]);
        ^^^
     aaa cannot be resolved
     ----------
     2 problems (2 errors)
x10c: Non-zero return code: 255
2 errors.
  1. File
    ADA_037f.x10
    29/Apr/12 7:26 AM
    0.2 kB
    Mikio Takeuchi
  2. Text File
    XTENLANG-3036.patch
    23/Apr/12 11:10 AM
    2 kB
    Salikh Zakirov
  3. Text File
    XTENLANG-3036-2.patch
    09/May/12 11:57 AM
    3 kB
    Salikh Zakirov

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mikio Takeuchi added a comment -

Reproduced.
Added a test case (AsyncInit2.x10) in r23695.

Show
Mikio Takeuchi added a comment - Reproduced. Added a test case (AsyncInit2.x10) in r23695.
Hide
Permalink
Salikh Zakirov added a comment -

One problem was that AsyncInitializer did not consider BackingArrayAccessAssign nodes that were created by transformation of async blocks. In this way a variable that was accessed from an async block two levels below top
was not identified as variable to be boxed by top-level async block.

Show
Salikh Zakirov added a comment - One problem was that AsyncInitializer did not consider BackingArrayAccessAssign nodes that were created by transformation of async blocks. In this way a variable that was accessed from an async block two levels below top was not identified as variable to be boxed by top-level async block.
Hide
Permalink
Salikh Zakirov added a comment -

XTENLANG-3036.patch fixes the test AsyncInit2. It passes precommit java tests, but I have not yet checked for regressions.

Show
Salikh Zakirov added a comment - XTENLANG-3036 .patch fixes the test AsyncInit2. It passes precommit java tests, but I have not yet checked for regressions.
Hide
Permalink
Mikio Takeuchi added a comment -

Fixed in r23712 by applying patch submitted by Salikh.
Now a local variable initialized in a nested async block compiles correctly.
Thanks Salikh!

Show
Mikio Takeuchi added a comment - Fixed in r23712 by applying patch submitted by Salikh. Now a local variable initialized in a nested async block compiles correctly. Thanks Salikh!
Hide
Permalink
Mikio Takeuchi added a comment -

The patch provided by Salikh, which I committed to trunk in r23712 caused regression of ADA_037f. Could you please look at it when you have time?

Show
Mikio Takeuchi added a comment - The patch provided by Salikh, which I committed to trunk in r23712 caused regression of ADA_037f. Could you please look at it when you have time?
Hide
Permalink
Mikio Takeuchi added a comment -

A test case simplified just for reproducing the regression.

Show
Mikio Takeuchi added a comment - A test case simplified just for reproducing the regression.
Hide
Permalink
Salikh Zakirov added a comment -

This is not for immediate commit.
the patch XTENLANG-3036-2.patch highlights the issues that cause compilation failure on ADA_037f.

More specifically: (a) I have forgot the local variable check in the previous patch.
(b) local variable check did not work because of inconsistencies in name and flag assignment in LocalDef and LocalInstance objects.

NOTE: this patch is not ready for commit as is, but feel free to use it as inspiration for a better fix.

Show
Salikh Zakirov added a comment - This is not for immediate commit. the patch XTENLANG-3036 -2.patch highlights the issues that cause compilation failure on ADA_037f. More specifically: (a) I have forgot the local variable check in the previous patch. (b) local variable check did not work because of inconsistencies in name and flag assignment in LocalDef and LocalInstance objects. NOTE: this patch is not ready for commit as is, but feel free to use it as inspiration for a better fix.
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2

People

  • Assignee:
    Unassigned
    Reporter:
    Salikh Zakirov
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: