X10

Serialization bug in Managed X10 when serializing Array[Object] with repeated references

Details

  • Number of attachments :
    1

Description

r22916 added a unit test at/ObjectArrayTest.x10 that passes in Native X10, but fails in Managed X10.

There appears to be a bug when an Array[Object] which contains repeated references (but not an Array[Blat] with repeated references) is serialized.

The bug appears in both the current trunk and the 2.2.1 release branch.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

failing until test

Show
David Grove added a comment - failing until test
Hide
Permalink
David Grove added a comment -

The test passes with the 2.2.0 release, so this is a regression wrt 2.2.0.

Show
David Grove added a comment - The test passes with the 2.2.0 release, so this is a regression wrt 2.2.0.
Hide
Permalink
David Grove added a comment -

Actually, the bug is that x10.core.Ref was being given the serialization id 0 (same as null). So any instance of ref (independent of repeated references) was being deserialized as null instead of as a x10.core.Ref. So serialization of x10.lang.Object instances on ManagedX10 was completely broken.

Show
David Grove added a comment - Actually, the bug is that x10.core.Ref was being given the serialization id 0 (same as null). So any instance of ref (independent of repeated references) was being deserialized as null instead of as a x10.core.Ref. So serialization of x10.lang.Object instances on ManagedX10 was completely broken.
Hide
Permalink
David Grove added a comment -

fixed serialization of x10.core.Ref in 22917.

Show
David Grove added a comment - fixed serialization of x10.core.Ref in 22917.
Hide
Permalink
Mikio Takeuchi added a comment -

Follow-on fix in r24105.
Replace x10.lang.RuntimeException with x10.lang.Error in preparation for elimating RuntimeException.

Show
Mikio Takeuchi added a comment - Follow-on fix in r24105. Replace x10.lang.RuntimeException with x10.lang.Error in preparation for elimating RuntimeException.

People

  • Assignee:
    David Grove
    Reporter:
    David Grove
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: