X10

Type constraint not propagated to return type of DistArray.restriction(Place)

Details

  • Type: Bug Bug
  • Status: In Progress In Progress
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: X10 2.2
  • Fix Version/s: X10 2.3.2
  • Component/s: X10 Compiler: Front-end
  • Labels:
    None
  • Testcase included:
    yes
  • Number of attachments :
    1

Description

The following code is legal and should compile without inserting any dynamic checks:

val a = DistArray.make[Rail[Int]](Dist.makeUnique(), ([i] : Point) => new Array[Int](1));
val b = a.restriction(here);
val x/* :Rail[Int] */ = b(0);
val y = x(1);

However, compiling with -VERBOSE_CHECKS with either X10 2.2 or SVN HEAD emits the following warning for the final line:

x10c -O -VERBOSE_CHECKS TestDistArrayRestriction.x10
/scratch/testx10/TestDistArrayRestriction.x10:17: Generated a dynamic check for the method call.

As indicated, the type of x should be Rail[Int] as it is an element of a DistArray of that type. It appears that the full type of DistArray[T] is not being propagated through to the return type of DistArray[T].restriction(p: Place): DistArray[T](rank).

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-2991 ArrayList[Rail[Int]] doesn't contain Rail[Int]s

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Peshansky added a comment -

The following turns this problem into a compile-time error, and illustrates the loss of type information:

public class XTENLANG_2875 {
    public static def main(Array[String]) {
        val a = DistArray.make[Rail[Int]](Dist.makeUnique(), ([i] : Point) => new Array[Int](1));
        val b = a.restriction(here);
        val x:Array[Rail[Int]] = [b(0)];
    }
}

The resulting error is:

./XTENLANG_2875.x10:5: Cannot assign expression to target; base types are incompatible.    
     	 Expression: [b.operator()(0)]    
     	 Expected base type: x10.array.Array[x10.array.Array[x10.lang.Int]{self.rank==1, self.zeroBased==true, self.rect==true, self.rail==true}]    
     	 Found base type: x10.array.Array[x10.array.Array[x10.lang.Int]{a.dist.region.rank==1, a!=null, b.dist.region.rank==1}]
1 error.
Show
Igor Peshansky added a comment - The following turns this problem into a compile-time error, and illustrates the loss of type information: public class XTENLANG_2875 { public static def main(Array[ String ]) { val a = DistArray.make[Rail[Int]](Dist.makeUnique(), ([i] : Point) => new Array[Int](1)); val b = a.restriction(here); val x:Array[Rail[Int]] = [b(0)]; } } The resulting error is: ./XTENLANG_2875.x10:5: Cannot assign expression to target; base types are incompatible. Expression: [b.operator()(0)] Expected base type: x10.array.Array[x10.array.Array[x10.lang.Int]{self.rank==1, self.zeroBased==true, self.rect==true, self.rail==true}] Found base type: x10.array.Array[x10.array.Array[x10.lang.Int]{a.dist.region.rank==1, a!=null, b.dist.region.rank==1}] 1 error.
Hide
Permalink
David Grove added a comment -

bulk defer minor issues to 2.2.2.

Show
David Grove added a comment - bulk defer minor issues to 2.2.2.
Hide
Permalink
Vijay Saraswat added a comment -

Related JIRA is critical.

Show
Vijay Saraswat added a comment - Related JIRA is critical.
Hide
Permalink
Vijay Saraswat added a comment - - edited

The problem manifests with:

 def m(a:DistArray[Int]) {
        val b <: Rail[Int] = a.restriction(here);
}
Show
Vijay Saraswat added a comment - - edited The problem manifests with: def m(a:DistArray[Int]) { val b <: Rail[Int] = a.restriction(here); }
Hide
Permalink
David Grove added a comment -

bulk defer of issues to 2.2.3.

Show
David Grove added a comment - bulk defer of issues to 2.2.3.
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2

People

  • Assignee:
    Vijay Saraswat
    Reporter:
    Josh Milthorpe
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: