java-interop: reachability test for catch statement does not understand java checked exceptions

FYI, I have a patch for that waiting on the contributor's agreement.

This code should pass type checking.

Igor – can you send me the patch so I can unblock Mikio?

Front end now accepts java.lang.Throwable (23304).

The patch (THROWS.patch) is attached. It does a couple of things differently from r23304, but has basically the same idea for handling this issue (your fix changed the semantics of the isThrowable() method, which may change the behavior in other contexts). It also has a better (more general) fix for generic annotations than r22975.

The important effect of this patch is changing the position of @Throws in the method declaration. Instead of

@Throws[Foo] @Throws[Bar] def m(...) { ... }
@Throws[Baz] def n(...):T { ... }

it now has a more familiar syntax

def m(...) @Throws[Foo] @Throws[Bar] { ... }
def n(...):T @Throws[Baz] { ... }

THROWS_EXAMPLE.patch is a companion patch to x10.interop illustrating the change in @Throws syntax.

Applied THROWS.patch in r23321. If you are using @Throws annotation in your code, please update it as described in Igor's comment.

I meant to get the opinions of the core team about this patch, since it's a syntactic change, and then commit it myself. I guess it's now de facto approved.
I'll commit the companion patch to the docs.

Actually I sent a note to application team's mailing list to collect their opinions about changing syntax and received endorsement from Vijay. It was an internal list and I failed to cc to you. Sorry about that.
We have waited full four months until this issue get fixed. We are under pressure for releasing java interoperability feature in the next point release, but we are still not ready to start backend work.

bulk close of 2.2.2 resolved issues.

Could you please describe the issues you still have, Avi?

        try {
            new java.io.FileInputStream("fish.txt");
        } catch (e: java.io.IOException) {
        } 

the catch statement is unreachable

catching java.lang.Throwable works OK

this is not a blocker

Dave, do you have a plan to fix this issue before 2.2.3 (GA in mid August, DCUT TBD), or should I describe it as an implementation limitation?

Fixed in 23999

Fixed regression with JavaException5.x10 in r24021.

bulk close of issues as part of making 2.2.3 release notes.