X10

Strange error message for overriding property method with normal method

Details

  • Type: Improvement Improvement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: X10 SVN HEAD
  • Fix Version/s: X10 2.3.2
  • Component/s: X10 Compiler: Front-end
  • Labels:
    None
  • Number of attachments :
    1

Description

Syntax error in the following code is reported with strange error message.

public class OverrideTest {
  static abstract class Sup {
    public abstract toString():String; // missing def
  }
  static class Sub extends Sup {
    public def toString():String = "hi";
  }
}

OverrideTest.x10:6: toString(): x10.lang.String in OverrideTest.Sub cannot override toString(): x10.lang.String in OverrideTest.Sup; attempting to assign weaker access privileges
1 error.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-2846 Better error message for omitted def keyword on a private method

  • Major - Major loss of function.
  • Reopened - This issue was once resolved, but the resolution was deemed incorrect. From here issues are either marked assigned or resolved.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Peshansky added a comment -

This is not a syntax error, but perfectly valid X10 code that declares a property method OverrideTest.Sup.toString(). Thus, the subclass method is weaker (does not have the property modifier).

Would it help if the message mentioned that the overridden method has the property modifier?

Show
Igor Peshansky added a comment - This is not a syntax error, but perfectly valid X10 code that declares a property method OverrideTest.Sup.toString() . Thus, the subclass method is weaker (does not have the property modifier). Would it help if the message mentioned that the overridden method has the property modifier?
Hide
Permalink
Mikio Takeuchi added a comment - - edited

I don't think it would be very helpful since the overridden method does not have property keyword.
By the way, is property keyword optional for defining property method?

Show
Mikio Takeuchi added a comment - - edited I don't think it would be very helpful since the overridden method does not have property keyword. By the way, is property keyword optional for defining property method?
Hide
Permalink
Igor Peshansky added a comment -

The property keyword is only optional if the def keyword is also omitted. To me this looks like a syntactic idiosyncrasy, and I would rather see at least the property modifier, or, preferably, both property and def, explicitly.

Show
Igor Peshansky added a comment - The property keyword is only optional if the def keyword is also omitted. To me this looks like a syntactic idiosyncrasy, and I would rather see at least the property modifier, or, preferably, both property and def , explicitly.
Hide
Permalink
Mikio Takeuchi added a comment -

Agreed. I would like to make at least property modifier explicit.

Show
Mikio Takeuchi added a comment - Agreed. I would like to make at least property modifier explicit.
Hide
Permalink
David Grove added a comment -

bulk defer minor issues to 2.2.2.

Show
David Grove added a comment - bulk defer minor issues to 2.2.2.
Hide
Permalink
David Grove added a comment -

bulk defer of issues to 2.2.3.

Show
David Grove added a comment - bulk defer of issues to 2.2.3.
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2

People

  • Assignee:
    Unassigned
    Reporter:
    Mikio Takeuchi
Vote (0)
Watch (3)

Dates

  • Created:
    Updated: