X10

The C++ backend should not rely on fake class names for function types in code generation

Details

  • Number of attachments :
    0

Description

In an attempt to fix XTENLANG-1647, I've renamed the fake classes used in the typechecker for function types, only to find that those new names were propagated into the generated C++ code. That change did not affect the Java backend. The C++ backend should handle function and closure types specially, like the Java backend does, and not use the built-in names.

Issue Links

is depended upon by

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-1647 Frontend should reject wrong function types

  • Major - Major loss of function.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Peshansky added a comment -

r21061 should make it a little easier to locate the relevant code in the Java backend.

Show
Igor Peshansky added a comment - r21061 should make it a little easier to locate the relevant code in the Java backend.
Hide
Permalink
David Grove added a comment -

fixed in 21067.

Not that happy with this change being made to the ASTs as it introduces tests for FunctionType vs. all other types in the C++ backend that weren't needed before. I think it would have been cleaner to just add an API method to ClassDef to get a canonical name for the type that would be a legal name in the target languages.

Show
David Grove added a comment - fixed in 21067. Not that happy with this change being made to the ASTs as it introduces tests for FunctionType vs. all other types in the C++ backend that weren't needed before. I think it would have been cleaner to just add an API method to ClassDef to get a canonical name for the type that would be a legal name in the target languages.
Hide
Permalink
David Grove added a comment -

bulk close of all 2.2.0 resolved issues.

Show
David Grove added a comment - bulk close of all 2.2.0 resolved issues.

People

  • Assignee:
    David Grove
    Reporter:
    Igor Peshansky
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: