X10

C++ backend produces incorrect code for simple for loop

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: X10 SVN HEAD
  • Fix Version/s: X10 2.2
  • Component/s: Native X10: Compiler Codegen
  • Labels:
    None
  • Environment:
    trunk r20275, NOT 2.1.1
  • Number of attachments :
    0

Description

The following code

public class Test {
    public static def main(Array[String](1)) {
        var count:Int = 10;
        var end:Int = count - 1;
        for (var i:Int = 0, mid:Int = count / 2; i < mid; i++, --end) { }
    }
}

based on similar code from X10Libs, produces the following post-compilation error:

~/projects/jira$ x10c++ Test.x10

x10c++: Test.cc: In static member function 'static void Test::main(x10aux::ref<x10::array::Array<x10aux::ref<x10::lang::String> > >)':    
     Test.cc:27: error: expected initializer before 'mid'    
     Test.cc:28: error: 'mid' was not declared in this scope    
x10c++: Non-zero return code: 1

To the best of my knowledge this code compiled on Friday afternoon (2/18/2011), so the regression is probably quite recent.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Minor Gordon added a comment -

This bug seems to have been caused by r20182. Please look into it.

Show
Minor Gordon added a comment - This bug seems to have been caused by r20182. Please look into it.
Minor Gordon made changes -
Field Original Value New Value
Assignee Janice Shepherd [ janice ]
Hide
Permalink
Janice Shepherd added a comment -

SVN R20287. Previous fix for XTENLANG-2372 had inadvently caused illegal C++ to be generated. This change restores the old processing of for_c and supplies a different fix for XTENLANG-2372.

Show
Janice Shepherd added a comment - SVN R20287. Previous fix for XTENLANG-2372 had inadvently caused illegal C++ to be generated. This change restores the old processing of for_c and supplies a different fix for XTENLANG-2372 .
Janice Shepherd made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s X10 2.2 [ 16002 ]
Resolution Fixed [ 1 ]
Hide
Permalink
David Grove added a comment -

bulk close of all 2.2.0 resolved issues.

Show
David Grove added a comment - bulk close of all 2.2.0 resolved issues.
David Grove made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Janice Shepherd
    Reporter:
    Minor Gordon
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: