X10

When inferring the return type, we should consider overriding methods and HasType.

Details

  • Number of attachments :
    0

Description

class TestOverridingAndHasType {
class A {
	def m():Int = 1;
	def t():Int = 1;
	def p():Double = 1;
}
class B extends A {
	def m() {throw new Exception();	} // ShouldNotBeERR
	def t() <: Int { throw new Exception();	} // ShouldNotBeERR ShouldNotBeERR
	def p() = 2;  // ShouldNotBeERR
}
class C {	
	def m() { throw new Exception();	} // infers void
	def m1():void { throw new Exception();	}
	def m2():Int { throw new Exception();	}
	def m3() <: Int {throw new Exception();	} // ShouldNotBeERR 
	def m4() <: void {throw new Exception();	}
}
}

Issue Links

duplicates

Improvement - An improvement or enhancement to an existing feature or task. XTENLANG-1584 Inference should look at the method we are overriding.

  • Major - Major loss of function.
  • Open - The issue is open and ready for the assignee to start work on it.
is depended upon by

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-2584 X10 2.2 frontend issues (umbrella)

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Improvement - An improvement or enhancement to an existing feature or task. XTENLANG-2439 X10 2.2 language design decisions (umbrella)

  • Blocker - Blocks development and/or testing work, production could not run
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.
is related to

Bug - A problem which impairs or prevents the functions of the product. XTENLANG-2480 Type bounds do not play nice with coercions

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Yoav Zibin made changes -
Field Original Value New Value
Description {code}
class TestOverridingAndHasType {
class A {
def m() = 1;
def t() = 1;
def p() = 1;
}
class B extends A {
def m() {throw new Exception(); } // ShouldNotBeERR
def t() <: Int { throw new Exception(); } // ShouldNotBeERR ShouldNotBeERR
def p() = 2; // ShouldNotBeERR
}
class C {
def m() { throw new Exception(); } // infers void
def m1():void { throw new Exception(); }
def m2():Int { throw new Exception(); }
def m3() <: Int {throw new Exception(); } // ERR
def m4() <: void {throw new Exception(); }
}
}
{code} 		{code}
class TestOverridingAndHasType {
class A {
def m():Int = 1;
def t():Int = 1;
def p():Double = 1;
}
class B extends A {
def m() {throw new Exception(); } // ShouldNotBeERR
def t() <: Int { throw new Exception(); } // ShouldNotBeERR ShouldNotBeERR
def p() = 2; // ShouldNotBeERR
}
class C {
def m() { throw new Exception(); } // infers void
def m1():void { throw new Exception(); }
def m2():Int { throw new Exception(); }
def m3() <: Int {throw new Exception(); } // ERR
def m4() <: void {throw new Exception(); }
}
}
{code}
Yoav Zibin made changes -
Summary When inferring the return type, we should consider overriding methods. When inferring the return type, we should consider overriding methods and HasType.
Description {code}
class TestOverridingAndHasType {
class A {
def m():Int = 1;
def t():Int = 1;
def p():Double = 1;
}
class B extends A {
def m() {throw new Exception(); } // ShouldNotBeERR
def t() <: Int { throw new Exception(); } // ShouldNotBeERR ShouldNotBeERR
def p() = 2; // ShouldNotBeERR
}
class C {
def m() { throw new Exception(); } // infers void
def m1():void { throw new Exception(); }
def m2():Int { throw new Exception(); }
def m3() <: Int {throw new Exception(); } // ERR
def m4() <: void {throw new Exception(); }
}
}
{code} 		{code}
class TestOverridingAndHasType {
class A {
def m():Int = 1;
def t():Int = 1;
def p():Double = 1;
}
class B extends A {
def m() {throw new Exception(); } // ShouldNotBeERR
def t() <: Int { throw new Exception(); } // ShouldNotBeERR ShouldNotBeERR
def p() = 2; // ShouldNotBeERR
}
class C {
def m() { throw new Exception(); } // infers void
def m1():void { throw new Exception(); }
def m2():Int { throw new Exception(); }
def m3() <: Int {throw new Exception(); } // ShouldNotBeERR
def m4() <: void {throw new Exception(); }
}
}
{code}
Igor Peshansky made changes -
Fix Version/s X10 2.2 [ 16002 ]
Igor Peshansky made changes -
Link This issue is related to XTENLANG-2480 [ XTENLANG-2480 ]
Igor Peshansky made changes -
Link This issue is depended upon by XTENLANG-2439 [ XTENLANG-2439 ]
Igor Peshansky made changes -
Link This issue is depended upon by XTENLANG-2584 [ XTENLANG-2584 ]
Igor Peshansky made changes -
Link This issue duplicates XTENLANG-1584 [ XTENLANG-1584 ]
Hide
Permalink
Igor Peshansky added a comment -

This is a duplicate of XTENLANG-1584 (overriding methods) and XTENLANG-2480 (HasType).

Show
Igor Peshansky added a comment - This is a duplicate of XTENLANG-1584 (overriding methods) and XTENLANG-2480 (HasType).
Igor Peshansky made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s X10 2.2 [ 16002 ]
Resolution Duplicate [ 3 ]
Hide
Permalink
David Grove added a comment -

bulk close of resolved issues with unspecified fix target (svn head, won't fix, duplicate, etc).

Show
David Grove added a comment - bulk close of resolved issues with unspecified fix target (svn head, won't fix, duplicate, etc).
David Grove made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Yoav Zibin
    Reporter:
    Yoav Zibin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: