X10

Method guards can only be made weaker by overriding (and it is not checked by the compiler)

Details

  • Number of attachments :
    0

Description

class A(i:Int) {
  def m() {i==1} {}
  def m2() {i!=0} {}
}
class B extends A {
  def this() { super(3); }
  def m() {i!=0} {}
  def m2() {i==1} {} // ShouldBeErr: guard can only be made stronger.
}

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Grove added a comment -

bulk assign all unscheduled issues to next release.

Show
David Grove added a comment - bulk assign all unscheduled issues to next release.
David Grove made changes -
Field Original Value New Value
Fix Version/s X10 2.2 [ 16002 ]
Hide
Permalink
Igor Peshansky added a comment - - edited

This is a method overriding issue.

Show
Igor Peshansky added a comment - - edited This is a method overriding issue.
Igor Peshansky made changes -
Assignee Igor Peshansky [ ipeshansky ] Vijay Saraswat [ vjsaraswat ]
Igor Peshansky made changes -
Component/s X10 Compiler: Front-end [ 13471 ]
Component/s X10 Compiler: Front-end Typechecking [ 14307 ]
Component/s X10 Compiler: Front-end Methods [ 14508 ]
Hide
Permalink
Vijay Saraswat added a comment -

Guard can only be made weaker.

Show
Vijay Saraswat added a comment - Guard can only be made weaker.
Hide
Permalink
Vijay Saraswat added a comment -

The error printed out now (r 21690) is:

C:\eclipsews\head8\Head8\src-x10\A.x10:8: m2 in B cannot override method in A; overriding method guard is not entailed.    
     	 Overiding Method in B:m2(){B#this.i==0}[]: void    
     	 Method in A:m2(){B#this.i!=10}[]: void
1 error.
Show
Vijay Saraswat added a comment - The error printed out now (r 21690) is: C:\eclipsews\head8\Head8\src-x10\A.x10:8: m2 in B cannot override method in A; overriding method guard is not entailed. Overiding Method in B:m2(){B# this .i==0}[]: void Method in A:m2(){B# this .i!=10}[]: void 1 error.
Hide
Permalink
Vijay Saraswat added a comment -

already fixed

Show
Vijay Saraswat added a comment - already fixed
Vijay Saraswat made changes -
Status Open [ 1 ] Resolved [ 5 ]
Resolution Fixed [ 1 ]
Hide
Permalink
David Grove added a comment -

bulk close of all 2.2.0 resolved issues.

Show
David Grove added a comment - bulk close of all 2.2.0 resolved issues.
David Grove made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Vijay Saraswat
    Reporter:
    Yoav Zibin
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: