X10

Add RunTestSuite to precommit

Details

  • Type: Bug Bug
  • Status: In Progress In Progress
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: X10 2.1.1
  • Fix Version/s: X10 2.3.2
  • Component/s: Build/Test Infrastructure
  • Labels:
    None
  • Number of attachments :
    0

Description

Can you add a call to RunTestSuite in precommit and make sure the exit code is 0 at the end?

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Peshansky added a comment -

First we have to fix the running time of RunTestSuite, or decide on a smaller set of tests (instead of the whole of x10.tests/examples). As it is, adding RunTestSuite will triple the time it takes to run the precommit script on a fast machine. We cannot afford this kind of delay.

Show
Igor Peshansky added a comment - First we have to fix the running time of RunTestSuite , or decide on a smaller set of tests (instead of the whole of x10.tests/examples ). As it is, adding RunTestSuite will triple the time it takes to run the precommit script on a fast machine. We cannot afford this kind of delay.
Hide
Permalink
Vijay Saraswat added a comment -

OK, make a call and do it...?

Show
Vijay Saraswat added a comment - OK, make a call and do it...?
Hide
Permalink
David Grove added a comment -

can afford to add about 30 seconds worth of execution for this test case. Please size accordingly.

Show
David Grove added a comment - can afford to add about 30 seconds worth of execution for this test case. Please size accordingly.
Hide
Permalink
David Grove added a comment -

not blocker.

Show
David Grove added a comment - not blocker.
Hide
Permalink
Yoav Zibin added a comment -

ok, then just run FrontEndTests_MustFailCompile.x10, it takes 15 seconds on my machine:

Running: [C:/cygwin/home/Yoav/intellij/sourceforge/x10.tests/examples/Misc/x10/frontend/tests/FrontEndTests_MustFailCompile.x10]
Compiler running time=14347

Show
Yoav Zibin added a comment - ok, then just run FrontEndTests_MustFailCompile.x10, it takes 15 seconds on my machine: Running: [C:/cygwin/home/Yoav/intellij/sourceforge/x10.tests/examples/Misc/x10/frontend/tests/FrontEndTests_MustFailCompile.x10] Compiler running time=14347
Hide
Permalink
David Grove added a comment -

bulk assign all unscheduled issues to next release.

Show
David Grove added a comment - bulk assign all unscheduled issues to next release.
Hide
Permalink
David Grove added a comment -

bulk defer of open issues to 2.2.2.

Show
David Grove added a comment - bulk defer of open issues to 2.2.2.
Hide
Permalink
David Grove added a comment -

bulk defer of issues to 2.2.3.

Show
David Grove added a comment - bulk defer of issues to 2.2.3.
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2

People

  • Assignee:
    David Grove
    Reporter:
    Yoav Zibin
Vote (0)
Watch (1)

Dates

  • Created:
    Updated: