X10
  1. X10
  2. XTENLANG-2181

Ensure that types of fields of T{c} reflect c.

    Details

    • Number of attachments :
      0

      Description

      X10ClassDef_c.classInvariant is wrong, i.e., it doesn't include X10ClassDecl_c.classInvariant.
      I see similar code for traversing the superclass and superinterface in both:

      X10ClassDecl_c.postBuildTypes 
      and
      X10ClassDef_c.getRootClause()
      

      However, no code piece actually adds X10ClassDecl_c.classInvariant to X10ClassDef_c.classInvariant

      Also, there are circularity issues when calculating the real clause.

      Finally, ConstrainedType_c doesn't pass its constraint to the fields in method fields

        Issue Links

          Activity

          David Grove made changes -
          Field Original Value New Value
          Fix Version/s X10 2.1.2 [ 16498 ]
          Hide
          David Grove added a comment -

          defer all non-critical 2.1.2 issues to 2.2.

          Show
          David Grove added a comment - defer all non-critical 2.1.2 issues to 2.2.
          David Grove made changes -
          Fix Version/s X10 2.2 [ 16002 ]
          Fix Version/s X10 2.1.2 [ 16498 ]
          Igor Peshansky made changes -
          Link This issue is depended upon by XTENLANG-2198 [ XTENLANG-2198 ]
          Hide
          Igor Peshansky added a comment -

          Looks like this is the root cause of class invariant problems like XTENLANG-2198. Needs to be fixed.

          Show
          Igor Peshansky added a comment - Looks like this is the root cause of class invariant problems like XTENLANG-2198 . Needs to be fixed.
          Igor Peshansky made changes -
          Priority Major [ 3 ] Critical [ 2 ]
          Description
          X10ClassDef_c.classInvariant is wrong, i.e., it doesn't include X10ClassDecl_c.classInvariant.
          I see similar code for traversing the superclass and superinterface in both:
          {code}
          X10ClassDecl_c.postBuildTypes
          and
          X10ClassDef_c.getRootClause()
          {code}
          However, no code piece actually adds X10ClassDecl_c.classInvariant to X10ClassDef_c.classInvariant

          Also, there are circularity issues when calculating the real clause.

          Finally, {{ConstrainedType_c}} doesn't pass its constraint to the fields in method {{fields}}
          X10ClassDef_c.classInvariant is wrong, i.e., it doesn't include X10ClassDecl_c.classInvariant.
          I see similar code for traversing the superclass and superinterface in both:
          {code}
          X10ClassDecl_c.postBuildTypes
          and
          X10ClassDef_c.getRootClause()
          {code}
          However, no code piece actually adds X10ClassDecl_c.classInvariant to X10ClassDef_c.classInvariant

          Also, there are circularity issues when calculating the real clause.

          Finally, {{ConstrainedType_c}} doesn't pass its constraint to the fields in method {{fields}}
          Hide
          Vijay Saraswat added a comment -

          Fixed rootClause and postBuildTypes relationship. There is none. ClassInvariant and realClause are maintained separately because in some places one is needed,and not the other.

          Work left to be done is ensuring that the types of fields of constrained type T

          {c}

          reflect c.

          Show
          Vijay Saraswat added a comment - Fixed rootClause and postBuildTypes relationship. There is none. ClassInvariant and realClause are maintained separately because in some places one is needed,and not the other. Work left to be done is ensuring that the types of fields of constrained type T {c} reflect c.
          Vijay Saraswat made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Igor Peshansky made changes -
          Link This issue is depended upon by XTENLANG-2584 [ XTENLANG-2584 ]
          Hide
          Igor Peshansky added a comment -

          This is a cleanup issue that doesn't seem to affect any actual programs. Deferring to 2.2.1.

          Show
          Igor Peshansky added a comment - This is a cleanup issue that doesn't seem to affect any actual programs. Deferring to 2.2.1.
          Igor Peshansky made changes -
          Fix Version/s X10 2.2.1 [ 17131 ]
          Fix Version/s X10 2.2 [ 16002 ]
          Igor Peshansky made changes -
          Link This issue is depended upon by XTENLANG-2584 [ XTENLANG-2584 ]
          Vijay Saraswat made changes -
          Summary Constraint system bugs Ensure that types of fields of T{c} reflect c.
          Vijay Saraswat made changes -
          Status In Progress [ 3 ] Open [ 1 ]
          Hide
          David Grove added a comment -

          bulk defer of open issues to 2.2.2.

          Show
          David Grove added a comment - bulk defer of open issues to 2.2.2.
          David Grove made changes -
          Fix Version/s X10 2.2.2 [ 17639 ]
          Fix Version/s X10 2.2.1 [ 17131 ]
          David Grove made changes -
          Link This issue is depended upon by XTENLANG-2971 [ XTENLANG-2971 ]
          Hide
          David Grove added a comment -

          bulk defer of issues to 2.2.3.

          Show
          David Grove added a comment - bulk defer of issues to 2.2.3.
          David Grove made changes -
          Fix Version/s X10 2.2.3 [ 18146 ]
          Fix Version/s X10 2.2.2 [ 17639 ]
          David Grove made changes -
          Fix Version/s X10 2.3 [ 17009 ]
          Fix Version/s X10 2.2.3 [ 18146 ]
          Hide
          David Grove added a comment -

          bulk defer of 2.3.0 open issues to 2.3.1.

          Show
          David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
          David Grove made changes -
          Fix Version/s X10 2.3.1 [ 18657 ]
          Fix Version/s X10 2.3 [ 17009 ]
          Hide
          David Grove added a comment -

          bulk defer to 2.3.2

          Show
          David Grove added a comment - bulk defer to 2.3.2
          David Grove made changes -
          Fix Version/s X10 2.3.2 [ 19010 ]
          Fix Version/s X10 2.3.1 [ 18657 ]
          Hide
          David Grove added a comment -

          bulk defer to 2.4.1.

          Show
          David Grove added a comment - bulk defer to 2.4.1.
          David Grove made changes -
          Fix Version/s X10 2.4.1 [ 19142 ]
          Fix Version/s X10 2.3.2 [ 19010 ]
          Hide
          David Grove added a comment -

          defer to 2.4.2

          Show
          David Grove added a comment - defer to 2.4.2
          David Grove made changes -
          Fix Version/s X10 2.4.2 [ 19827 ]
          Fix Version/s X10 2.4.1 [ 19142 ]
          Hide
          David Grove added a comment -

          bulk defer to 2.4.3

          Show
          David Grove added a comment - bulk defer to 2.4.3
          David Grove made changes -
          Fix Version/s X10 2.4.2 [ 19827 ]
          Fix Version/s X10 2.4.3 [ 20024 ]
          Hide
          David Grove added a comment -

          bulk defer to 2.4.4

          Show
          David Grove added a comment - bulk defer to 2.4.4
          David Grove made changes -
          Fix Version/s X10 2.4.3 [ 20024 ]
          Fix Version/s X10 2.4.4 [ 20386 ]
          David Grove made changes -
          Fix Version/s X10 2.4.4 [ 20386 ]
          Fix Version/s X10 2.5.1 [ 20503 ]

            People

            • Assignee:
              Vijay Saraswat
              Reporter:
              Yoav Zibin
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: