X10

Better parser recovery techniques

Details

  • Number of attachments :
    1

Description

Compiling the attached file:

I think the error message is not useful. Surely a better message is possible.

../bin/x10c x.x10
/Users/sjfink/work/x10-trunk/x10.dist/samples/x.x10:12: Syntax error: Unexpected input ignored: "ERROR_TOKEN"
def this(byte c, double p) {
^

/Users/sjfink/work/x10-trunk/x10.dist/samples/x.x10:12: Syntax error: Unexpected input ignored: "ERROR_TOKEN"
def this(byte c, double p)

{ ^--------------^ /Users/sjfink/work/x10-trunk/x10.dist/samples/x.x10:17: Syntax error: Unexpected input ignored: "ERROR_TOKEN" }
  1. File
    x.x10
    27/Jul/10 1:59 PM
    0.3 kB
    Stephen Fink

Issue Links

is depended upon by

New Feature - A new feature of the product, which has yet to be developed. XTENLANG-2429 Add package declaration node to synthetic ASTs

  • Critical - Crashes, loss of data, severe memory leak.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Igor Peshansky made changes -
Field Original Value New Value
Assignee Philippe Charles [ pcharles ]
Hide
Permalink
Stephen Fink added a comment -

I get this frequently.

Show
Stephen Fink added a comment - I get this frequently.
Stephen Fink made changes -
Issue Type Improvement [ 4 ] Bug [ 1 ]
Priority Major [ 3 ] Critical [ 2 ]
Hide
Permalink
Vijay Saraswat added a comment -

To be fixed with the prosthetic work being done by Philippe.

Show
Vijay Saraswat added a comment - To be fixed with the prosthetic work being done by Philippe.
Hide
Permalink
Igor Peshansky added a comment -

Bulk-assigning unscheduled issues to the next release.

Show
Igor Peshansky added a comment - Bulk-assigning unscheduled issues to the next release.
Igor Peshansky made changes -
Fix Version/s X10 2.1.0 [ 16496 ]
Hide
Permalink
David Grove added a comment -

bulk defer of unresolved 2.1.0 bugs to 2.1.1.

Show
David Grove added a comment - bulk defer of unresolved 2.1.0 bugs to 2.1.1.
David Grove made changes -
Fix Version/s X10 2.1.1 [ 16497 ]
Fix Version/s X10 2.1.0 [ 16496 ]
Hide
Permalink
David Grove added a comment -

bulk move of all unresolved issues from 2.1.1 to 2.1.2

Show
David Grove added a comment - bulk move of all unresolved issues from 2.1.1 to 2.1.2
David Grove made changes -
Fix Version/s X10 2.1.2 [ 16498 ]
Fix Version/s X10 2.1.1 [ 16497 ]
Hide
Permalink
Vijay Saraswat added a comment -

Downgraded to Major, Urgency High.

These errors are common for people moving from Java, however, a quick glance at the code is often enough to understand what is wrong – particularly in X10DT where all the offending places get marked, and you can also see correct usage on the same page if the source code file is big enough and has correct usage patterns.

But yes, the parser should do a better job.

Show
Vijay Saraswat added a comment - Downgraded to Major, Urgency High. These errors are common for people moving from Java, however, a quick glance at the code is often enough to understand what is wrong – particularly in X10DT where all the offending places get marked, and you can also see correct usage on the same page if the source code file is big enough and has correct usage patterns. But yes, the parser should do a better job.
Vijay Saraswat made changes -
Fix Version/s X10 2.1.2 [ 16498 ]
Priority Critical [ 2 ] Major [ 3 ]
Fix Version/s X10 2.2 [ 16002 ]
Hide
Permalink
Igor Peshansky added a comment -

This is basically a problem of recovering partial ASTs in files with syntax errors, a.k.a. AST prostheses. We'll use this JIRA issue to track the progress of this work.

Show
Igor Peshansky added a comment - This is basically a problem of recovering partial ASTs in files with syntax errors, a.k.a. AST prostheses. We'll use this JIRA issue to track the progress of this work.
Igor Peshansky made changes -
Summary Error message: Unexpected input ignored: "ERROR_TOKEN" Better parser recovery techniques
Fix Version/s X10 2.2.1 [ 17131 ]
Fix Version/s X10 2.2 [ 16002 ]
Priority Major [ 3 ] Critical [ 2 ]
Component/s X10 Compiler: Front-end Parser [ 14505 ]
Igor Peshansky made changes -
Link This issue is depended upon by XTENLANG-2429 [ XTENLANG-2429 ]
Hide
Permalink
David Grove added a comment -

move reporter from Steve to Dave

Show
David Grove added a comment - move reporter from Steve to Dave
David Grove made changes -
Reporter Stephen Fink [ sjfink ] David Grove [ dgrove ]
Hide
Permalink
David Grove added a comment -

defer to 2.2.2

Show
David Grove added a comment - defer to 2.2.2
David Grove made changes -
Fix Version/s X10 2.2.2 [ 17639 ]
Fix Version/s X10 2.2.1 [ 17131 ]
David Grove made changes -
Link This issue is depended upon by XTENLANG-2971 [ XTENLANG-2971 ]
David Grove made changes -
Link This issue is depended upon by XTENLANG-2971 [ XTENLANG-2971 ]
Hide
Permalink
David Grove added a comment -

bulk defer of issues to 2.2.3.

Show
David Grove added a comment - bulk defer of issues to 2.2.3.
David Grove made changes -
Fix Version/s X10 2.2.3 [ 18146 ]
Fix Version/s X10 2.2.2 [ 17639 ]
David Grove made changes -
Assignee Philippe Charles [ pcharles ]
David Grove made changes -
Fix Version/s X10 2.3 [ 17009 ]
Fix Version/s X10 2.2.3 [ 18146 ]
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
David Grove made changes -
Fix Version/s X10 2.3.1 [ 18657 ]
Fix Version/s X10 2.3 [ 17009 ]
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2
David Grove made changes -
Fix Version/s X10 2.3.2 [ 19010 ]
Fix Version/s X10 2.3.1 [ 18657 ]

People

  • Assignee:
    Unassigned
    Reporter:
    David Grove
Vote (0)
Watch (2)

Dates

  • Created:
    Updated: