X10

Uninformative error message on access to inherited ambiguous field

Details

  • Number of attachments :
    0

Description

The following should not compile, because Ithree requires two boom fields (with different values, for fun, though the spec excludes the case where they are the same.) It does compile.

interface Ione {
  public static val boom = 1;
}


interface Itwo {
  public static val boom = 2;
}

interface Ithree extends Ione, Itwo {}

The fix is not easy. First it is in polyglot's code:

            try {
                return ts.findField(this.currentClass(), ts.FieldMatcher(this.currentClass(), name, this));
            }
            catch (SemanticException e) {
                return null;  // todo: we loose the error message! e.g., "Field XXX is ambiguous; it is defined in both ..." 
            }

Second, you need to fix this pattern of findVariableSilent, which should simply call findVariable, and if there is an exception, return null. But instead it does the opposite.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Igor Peshansky added a comment - - edited

This should most definitely compile, because static fields can be (a) shadowed, and (b) unambiguously resolved by prepending them with the name of the containing class or interface. Any code that uses Ithree.boom should not compile, because of an ambiguity in referencing boom, but simply defining Ithree should not cause a compilation error.

If there is text in the spec that says that this should not compile, please reopen the issue and we'll see how that can be addressed (perhaps by fixing the spec).

Show
Igor Peshansky added a comment - - edited This should most definitely compile, because static fields can be (a) shadowed, and (b) unambiguously resolved by prepending them with the name of the containing class or interface. Any code that uses Ithree.boom should not compile, because of an ambiguity in referencing boom , but simply defining Ithree should not cause a compilation error. If there is text in the spec that says that this should not compile, please reopen the issue and we'll see how that can be addressed (perhaps by fixing the spec).
Hide
Permalink
Bard Bloom added a comment -

Ah, curse it, I'd picked up an old Java spec to crib off of. Need to fix this, as Igor says.

Show
Bard Bloom added a comment - Ah, curse it, I'd picked up an old Java spec to crib off of. Need to fix this, as Igor says.
Hide
Permalink
David Grove added a comment -

defer all non-critical X10 issues to 2.1.0.

Show
David Grove added a comment - defer all non-critical X10 issues to 2.1.0.
Hide
Permalink
Yoav Zibin added a comment -

We should fix the error messages that the compiler gives for this error:
The second message is nice, but the first one is wrong.

public class Hello implements Ithree {	
	public static def main(args: Rail[String]) {
		val x = boom; // ERR: Could not find field or local variable "boom".
		val y = Ithree.boom; // ERR: Field boom is ambiguous; it is defined in both Ione and Itwo.
	}
}
interface Ione {
  public static val boom = 1;
}
interface Itwo {
  public static val boom = 2;
}
interface Ithree extends Ione, Itwo {}
Show
Yoav Zibin added a comment - We should fix the error messages that the compiler gives for this error: The second message is nice, but the first one is wrong. public class Hello implements Ithree { public static def main(args: Rail[ String ]) { val x = boom; // ERR: Could not find field or local variable "boom" . val y = Ithree.boom; // ERR: Field boom is ambiguous; it is defined in both Ione and Itwo. } } interface Ione { public static val boom = 1; } interface Itwo { public static val boom = 2; } interface Ithree extends Ione, Itwo {}
Hide
Permalink
Igor Peshansky added a comment -

Bulk defer all non-critical, non-blocker frontend issues to 2.1.0.

Show
Igor Peshansky added a comment - Bulk defer all non-critical, non-blocker frontend issues to 2.1.0.
Hide
Permalink
David Grove added a comment -

bulk defer of unresolved 2.1.0 bugs to 2.1.1.

Show
David Grove added a comment - bulk defer of unresolved 2.1.0 bugs to 2.1.1.
Hide
Permalink
David Grove added a comment -

bulk move of all unresolved issues from 2.1.1 to 2.1.2

Show
David Grove added a comment - bulk move of all unresolved issues from 2.1.1 to 2.1.2
Hide
Permalink
David Grove added a comment -

defer all non-critical 2.1.2 issues to 2.2.

Show
David Grove added a comment - defer all non-critical 2.1.2 issues to 2.2.
Hide
Permalink
Igor Peshansky added a comment -

As Yoav says above, the error message for unqualified access to field boom ought to be fixed. Unfortunately, fixing it would require changing the way we disambiguate unqualified fields and locals. Deferring to 2.2.1.

Show
Igor Peshansky added a comment - As Yoav says above, the error message for unqualified access to field boom ought to be fixed. Unfortunately, fixing it would require changing the way we disambiguate unqualified fields and locals. Deferring to 2.2.1.
Hide
Permalink
David Grove added a comment -

bulk defer of open issues to 2.2.2.

Show
David Grove added a comment - bulk defer of open issues to 2.2.2.
Hide
Permalink
David Grove added a comment -

bulk defer of issues to 2.2.3.

Show
David Grove added a comment - bulk defer of issues to 2.2.3.
Hide
Permalink
David Grove added a comment -

bulk defer of 2.3.0 open issues to 2.3.1.

Show
David Grove added a comment - bulk defer of 2.3.0 open issues to 2.3.1.
Hide
Permalink
David Grove added a comment -

bulk defer to 2.3.2

Show
David Grove added a comment - bulk defer to 2.3.2

People

  • Assignee:
    Unassigned
    Reporter:
    Bard Bloom
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:

Time Tracking

Estimated:
3d
Original Estimate - 3 days
Remaining:
3d
Remaining Estimate - 3 days
Logged:
Not Specified
Time Spent - Not Specified