X10
  1. X10
  2. XTENLANG-1272

Source editor blames current source file for errors in other files

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: X10 2.0.3
    • Fix Version/s: X10 2.0.4
    • Component/s: X10DT Source Editor
    • Labels:
      None
    • Number of attachments :
      0

      Description

      If while processing A.x10, a reference to B.x10 is encountered, the compiler front end processes B.x10, and may issue messages regarding various kinds of errors on B.x10.

      If the compiler front-end was invoked on behalf of the source editor, such errors will actually be flagged on A.x10, since the CompilerDelegate uses an anonymous AbstractErrorQueue that doesn't differentiate errors on distinct files. It should really only report errors on the file for which it was intended (since the CompilerDelegate is responsible for a single source file, the one in the open source editor).

        Activity

        Hide
        Mandana Vaziri added a comment -

        To fix this bug, I also had to do filtering inside MessageHandlerAdapter because syntactic errors don't go into the AbstractErrorQueue. MessageHandlerAdapter lives in IMP and the fix required a change in the constructor, so I copied it in X10DT and did the proper filtering in a class called MessageHandlerAdapterFilter. I could not subclass MessageHandlerAdapter because fIMPHandler would not be visible.

        Show
        Mandana Vaziri added a comment - To fix this bug, I also had to do filtering inside MessageHandlerAdapter because syntactic errors don't go into the AbstractErrorQueue. MessageHandlerAdapter lives in IMP and the fix required a change in the constructor, so I copied it in X10DT and did the proper filtering in a class called MessageHandlerAdapterFilter. I could not subclass MessageHandlerAdapter because fIMPHandler would not be visible.
        Hide
        David Grove added a comment -

        bulk close of all resolved issues as part of closing 2.0.4 items.

        Show
        David Grove added a comment - bulk close of all resolved issues as part of closing 2.0.4 items.

          People

          • Assignee:
            Mandana Vaziri
            Reporter:
            Robert M. Fuhrer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 1 day
              1d
              Remaining:
              Remaining Estimate - 1 day
              1d
              Logged:
              Time Spent - Not Specified
              Not Specified