XStream

AttributeMapper should use ReflectionProvider for looking up fields

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.3.1
  • Fix Version/s: 1.4
  • Component/s: Core
  • Labels:
    None

Description

Currently AttributeMapper uses Fields.find to lookup Fields. This is problematic because Fields.find is not cached like ReflectionProvider/FieldDictionary. This should be changed to maximize performance.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Keith Kowalczykowski added a comment -

Patch to fix this issue. Seeing ~15% speedup.

Show
Keith Kowalczykowski added a comment - Patch to fix this issue. Seeing ~15% speedup.
Keith Kowalczykowski made changes -
Field Original Value New Value
Attachment attribute-mapper-reflection-provider.patch [ 41147 ]
Hide
Permalink
Jörg Schaible added a comment -

Thanks for this, Keith. Applied to HEAD.

Show
Jörg Schaible added a comment - Thanks for this, Keith. Applied to HEAD.
Jörg Schaible made changes -
Status Open [ 1 ] Resolved [ 5 ]
Fix Version/s 1.x Maintenance [ 12873 ]
Resolution Fixed [ 1 ]
Jörg Schaible made changes -
Fix Version/s 1.4 [ 17519 ]
Fix Version/s 1.x Maintenance [ 12873 ]
Jörg Schaible made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

  • Assignee:
    Jörg Schaible
    Reporter:
    Keith Kowalczykowski
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: