XStream
  1. XStream
  2. XSTR-564

AttributeMapper should use ReflectionProvider for looking up fields

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.4
    • Component/s: Core
    • Labels:
      None

      Description

      Currently AttributeMapper uses Fields.find to lookup Fields. This is problematic because Fields.find is not cached like ReflectionProvider/FieldDictionary. This should be changed to maximize performance.

        Activity

        Hide
        Keith Kowalczykowski added a comment -

        Patch to fix this issue. Seeing ~15% speedup.

        Show
        Keith Kowalczykowski added a comment - Patch to fix this issue. Seeing ~15% speedup.
        Hide
        Jörg Schaible added a comment -

        Thanks for this, Keith. Applied to HEAD.

        Show
        Jörg Schaible added a comment - Thanks for this, Keith. Applied to HEAD.

          People

          • Assignee:
            Jörg Schaible
            Reporter:
            Keith Kowalczykowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: