XStream
  1. XStream
  2. XSTR-563

Modify ObjectIdDictionary to use ReferenceQueue for cleaning-up WeakReferences

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.1
    • Fix Version/s: 1.4
    • Component/s: Core
    • Labels:
      None

      Description

      Per discussion on the dev mailing list, the appropriate way to cleanup weak references is to use a ReferenceQueue, instead of iterating over all of the objects. Attached is a patch which implements this fix for ObjectIdDictionary.

        Activity

        Hide
        Keith Kowalczykowski added a comment -

        Updated patch to fix test case.

        Show
        Keith Kowalczykowski added a comment - Updated patch to fix test case.
        Keith Kowalczykowski made changes -
        Field Original Value New Value
        Attachment objectiddictionary-weak-reference.patch [ 41146 ]
        Keith Kowalczykowski made changes -
        Attachment objectiddictionary-weak-reference.patch [ 41140 ]
        Hide
        Jörg Schaible added a comment -

        Applied. Thanks for this patch!

        Show
        Jörg Schaible added a comment - Applied. Thanks for this patch!
        Jörg Schaible made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.x Maintenance [ 12873 ]
        Resolution Fixed [ 1 ]
        Jörg Schaible made changes -
        Fix Version/s 1.4 [ 17519 ]
        Fix Version/s 1.x Maintenance [ 12873 ]
        Jörg Schaible made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jörg Schaible
            Reporter:
            Keith Kowalczykowski
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: