History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: XSTR-438
Type: Improvement Improvement
Status: Closed Closed
Resolution: Duplicate
Priority: Minor Minor
Assignee: Unassigned
Reporter: Norbert Kuck
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XStream

Please add SAP JVM as a recognized VM

Created: 02/Oct/07 07:11 AM   Updated: 02/Oct/07 07:26 AM
Component/s: None
Affects Version/s: None
Fix Version/s: None

Issue Links:
Duplicate
 

JDK version and platform: SAP JVM (any version)


 Description  « Hide
We have had bug reports from customers claiming that XStream did not work properly for them if they used SAP's own Java VM. We have been able to track this down to the code in XStream where the Java VM vendor is checked.

Please add the SAP JVM to the list of VMS that can use a Sun14 reflection provider. The implementation of SAP JVM is very close to the Sun VM and it is therefore safe to assume that implementation specific tricks using reflection and sun.misc.Unsafe that work on the Sun VM will also work on SAP JVM. Our tests have confirmed that so far.

The SAP JVM reports java.vm.vendor as 'SAP AG'.

Specifically, we would suggest that in the class com.thoughtworks.xstream.core.JVM the following method be added:
private static boolean isSAP() { return System.getProperty("java.vm.vendor").indexOf("SAP AG") != -1; }

and that in the method canUseSun14ReflectionProvider() an appropriate "|| isSAP()" be added.



 All   Comments   Change History      Sort Order: Ascending order - Click to sort in descending order
Joerg Schaible - 02/Oct/07 07:26 AM
Norbert,
I close this issue as duplicate. Although it is probably that your proposed changes are enough, we cannot be sure. See my comments at the duplicate XSTR-431. Since you're employee from SAP you might be able to help to resolve this completely. Thanks a lot.
  • Jörg