History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: XPR-408
Type: Task Task
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Jacques Morel
Reporter: Jeremy K. Truax
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
xplanner

Change the default value for JNDI debug from boolean to integer

Created: 13/Jun/07 02:53 PM   Updated: 14/Jun/07 03:40 PM
Component/s: Security
Affects Version/s: 0.7
Fix Version/s: 0.8b3

Time Tracking:
Not Specified

Environment: JDK 1.6, Tomcat 5.5.9, CentOS Linux 4.3 xplanner 0.7b7

Patch attached: Yes


 Description  « Hide
In the xplanner.properties file there is a default value for debug like so: (line 170ish)

#xplanner.security.login[1].option.debug=true

This is misleading as debug is actually an integer value when it's copied over to the JNDIAuthenticatorImpl class and it fails trying to convert from a string "true" to an integer. In fact, it fails silently which brings up another issue.

In com/sabre/security/jndi/JNDIAuthenticatorImpl.java around line 280, the function setOptions(), it catches an exception but does not print a stack trace or anything so it is silent and was therefore really hard to find out why the above issue was happening.

I suggest printing a stacktrace there like so:

catch (Exception e) {
 e.printStackTrace();
}



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Jeremy K. Truax - 13/Jun/07 03:05 PM
Another note, there's a default option set also:

xplanner.security.login[1].option.connectionName

From the code, it looks like it needs to be connectionUser instead. If that is not corrected, LDAP always tries to do an anonymous bind.

Jeremy K. Truax - 14/Jun/07 02:17 PM
Hi Jacques thanks for getting to this quickly.

I did notice in the diff that you changed it for the XPlannerLoginModule but the JNDILoginModule still has a debug=true as default value.

Just thought I'd give a heads up. Thanks again.

Jacques Morel - 14/Jun/07 03:40 PM
Good catch. In fact XPlannerLoginModule does not support a debug property :-) So you caught 2 mistakes. Thanks