[#XPR-19] External Wiki linking in 0.7

xplanner

External Wiki linking in 0.7

Created: 20/May/05 07:03 AM Updated: 18/Feb/07 01:20 AM

Component/s:

Wiki

Affects Version/s:

0.7

Fix Version/s:

0.7

Time Tracking:

Original Estimate:

2 hours

Remaining Estimate:

1 hour, 30 minutes

Time Spent:

1 hour, 30 minutes

File Attachments:

xplanner-custom.properties (0.6 kb)

Environment:

Issue Links:

Related

This issue relates to:

XPR-232 Multiple occurences of the same wiki word in the same line are rendered incorrectly.

This issue is related to:

XPR-232 Multiple occurences of the same wiki word in the same line are rendered incorrectly.

Description

« Hide

I've installed the CVS head version of XPlanner to test, and after a bit of messing about have managed to upgrade a copy of my existing database. Things generally seem to be working, but wiki linking appears to have gone a bit wrong.

A note consisting of the following text:

"The following should be a link to an existing page on our external wiki : CoreFiling . The following is a link to something non-existent: NonExistentPage ."

renders as:

<div class="note_body">The following should be a link to an existing page on our external wiki : <a href="%3Ca%20href=%22http://tugela:8888/wiki/jsp/Wiki?CoreFiling%22%20target=%22_top%22%3Ehttp://tugela:8888/wiki/jsp/Wiki?CoreFiling%3C/a%3E">CoreFiling</a> . The following is a link to something non-existent: NonExistentPage<a href="%3Ca%20href=%22http://tugela:8888/wiki/jsp/Wiki?topic=NonExistentPage&action=action_edit%22%20target=%22_top%22%3Ehttp://tugela:8888/wiki/jsp/Wiki?topic=NonExistentPage&action=action_edit%3C/a%3E">?</a> .
</div>

The basic link behind the cruft seems right, but it looks almost as if it has been processed twice...

I have attached my xplanner-custom.properties. My xplanner.properties is unchanged from the CVS version.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Lucian Holland - 06/Jun/05 03:38 AM

I've found some time to look into this issue, and it appears that in the delightful TwikiFormat.format method, the chunk of code that handles external wiki linking has been moved after the chunk of code that handles URLs; the result is that the wiki formatter creates external wiki links, which the URL reformatting code then merrily processes again! For the time being I have moved the URL handling bit to immediately before the wiki linking bit and this fixes the problem for me. I assume the real answer is probably to fix the pattern used by the URL stuff not to match things already in an href attribute; but it's Monday morning and I can't face large chunks of regex right now... :-)

[ Permlink | « Hide ]

Jacques Morel - 23/Jul/05 11:15 PM

Lucian,

Did you have more time to look into this?

Jacques

[ Permlink | « Hide ]

Lucian Holland - 25/Jul/05 08:53 AM

Jacques,

Sorry - I'm afraid I've been very snowed under and at the moment we're still using my original patch - just switching the order of the two chunks around. I think it's unlikely that I'll get a chance to look at it any further in the near future....

Sorry,
Lucian

[ Permlink | « Hide ]

James Beard - 26/Jan/06 07:02 AM

Waiting for feedback from mailing list on suggestion that work around is actually the preferred solution.

[ Permlink | « Hide ]

Lucian Holland - 01/Mar/06 06:11 AM

I believe that the same piece of code is responsible for XPR-232 as well - needs to be reviewed quite carefully...

[ Permlink | « Hide ]

Piotr Uryga - 14/Feb/07 06:16 AM

So is it commited to SVN and is ready to be included in new releases ?

[ Permlink | « Hide ]

Jacques Morel - 16/Feb/07 01:23 AM

More work needs to be done apparently
See for more details: https://sourceforge.net/forum/message.php?msg_id=4087347

[ Permlink | « Hide ]

Piotr Uryga - 16/Feb/07 05:37 AM

Erm... as far as I understand this topic You stated there that it should work from 0.7b7 branch (link here: https://sourceforge.net/forum/message.php?msg_id=3750633) Am I right ?

[ Permlink | « Hide ]

Jacques Morel - 18/Feb/07 01:20 AM

Piotr, unfortunately, not all case are covered. I need to look into it closer to make sure all cases are indeed working. Jacques