External Wiki linking in 0.7

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: 0.7
  • Fix Version/s: 0.7
  • Component/s: Wiki
  • Labels:
    None
  • Environment:
    Xplanner CVS Head; Redhat Fedora Core 2; Jetty 4.2.22; Java 1.4; VQWiki 2.7.1

Description

I've installed the CVS head version of XPlanner to test, and after a bit of messing about have managed to upgrade a copy of my existing database. Things generally seem to be working, but wiki linking appears to have gone a bit wrong.

A note consisting of the following text:

"The following should be a link to an existing page on our external wiki : CoreFiling . The following is a link to something non-existent: NonExistentPage ."

renders as:

<div class="note_body">The following should be a link to an existing page on our external wiki : <a href="%3Ca%20href=%22http://tugela:8888/wiki/jsp/Wiki?CoreFiling%22%20target=%22_top%22%3Ehttp://tugela:8888/wiki/jsp/Wiki?CoreFiling%3C/a%3E">CoreFiling</a> . The following is a link to something non-existent: NonExistentPage<a href="%3Ca%20href=%22http://tugela:8888/wiki/jsp/Wiki?topic=NonExistentPage&action=action_edit%22%20target=%22_top%22%3Ehttp://tugela:8888/wiki/jsp/Wiki?topic=NonExistentPage&action=action_edit%3C/a%3E">?</a> .
</div>

The basic link behind the cruft seems right, but it looks almost as if it has been processed twice...

I have attached my xplanner-custom.properties. My xplanner.properties is unchanged from the CVS version.

Issue Links

is related to

Bug - A problem which impairs or prevents the functions of the product. XPR-232 Multiple occurences of the same wiki word in the same line are rendered incorrectly.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.
relates to

Bug - A problem which impairs or prevents the functions of the product. XPR-232 Multiple occurences of the same wiki word in the same line are rendered incorrectly.

  • Minor - Minor loss of function, or other problem where easy workaround is present.
  • Open - The issue is open and ready for the assignee to start work on it.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Lucian Holland added a comment -
I've found some time to look into this issue, and it appears that in the delightful TwikiFormat.format method, the chunk of code that handles external wiki linking has been moved after the chunk of code that handles URLs; the result is that the wiki formatter creates external wiki links, which the URL reformatting code then merrily processes again! For the time being I have moved the URL handling bit to immediately before the wiki linking bit and this fixes the problem for me. I assume the real answer is probably to fix the pattern used by the URL stuff not to match things already in an href attribute; but it's Monday morning and I can't face large chunks of regex right now... :-)
Show
Lucian Holland added a comment - I've found some time to look into this issue, and it appears that in the delightful TwikiFormat.format method, the chunk of code that handles external wiki linking has been moved after the chunk of code that handles URLs; the result is that the wiki formatter creates external wiki links, which the URL reformatting code then merrily processes again! For the time being I have moved the URL handling bit to immediately before the wiki linking bit and this fixes the problem for me. I assume the real answer is probably to fix the pattern used by the URL stuff not to match things already in an href attribute; but it's Monday morning and I can't face large chunks of regex right now... :-)
Hide
Permalink
Jacques Morel added a comment -
Lucian,

Did you have more time to look into this?

Jacques
Show
Jacques Morel added a comment - Lucian, Did you have more time to look into this? Jacques
Hide
Permalink
Lucian Holland added a comment -
Jacques,

Sorry - I'm afraid I've been very snowed under and at the moment we're still using my original patch - just switching the order of the two chunks around. I think it's unlikely that I'll get a chance to look at it any further in the near future....

Sorry,
Lucian
Show
Lucian Holland added a comment - Jacques, Sorry - I'm afraid I've been very snowed under and at the moment we're still using my original patch - just switching the order of the two chunks around. I think it's unlikely that I'll get a chance to look at it any further in the near future.... Sorry, Lucian
Hide
Permalink
James Beard added a comment -
Waiting for feedback from mailing list on suggestion that work around is actually the preferred solution.
Show
James Beard added a comment - Waiting for feedback from mailing list on suggestion that work around is actually the preferred solution.
Hide
Permalink
Lucian Holland added a comment -
I believe that the same piece of code is responsible for XPR-232 as well - needs to be reviewed quite carefully...
Show
Lucian Holland added a comment - I believe that the same piece of code is responsible for XPR-232 as well - needs to be reviewed quite carefully...
Hide
Permalink
Piotr Uryga added a comment -
So is it commited to SVN and is ready to be included in new releases ?
Show
Piotr Uryga added a comment - So is it commited to SVN and is ready to be included in new releases ?
Hide
Permalink
Jacques Morel added a comment -
More work needs to be done apparently
See for more details: https://sourceforge.net/forum/message.php?msg_id=4087347
Show
Jacques Morel added a comment - More work needs to be done apparently See for more details: https://sourceforge.net/forum/message.php?msg_id=4087347
Hide
Permalink
Piotr Uryga added a comment -
Erm... as far as I understand this topic You stated there that it should work from 0.7b7 branch (link here: https://sourceforge.net/forum/message.php?msg_id=3750633) Am I right ?
Show
Piotr Uryga added a comment - Erm... as far as I understand this topic You stated there that it should work from 0.7b7 branch (link here: https://sourceforge.net/forum/message.php?msg_id=3750633) Am I right ?
Hide
Permalink
Jacques Morel added a comment -
Piotr, unfortunately, not all case are covered. I need to look into it closer to make sure all cases are indeed working. Jacques
Show
Jacques Morel added a comment - Piotr, unfortunately, not all case are covered. I need to look into it closer to make sure all cases are indeed working. Jacques

People

  • Assignee:
    Jacques Morel
    Reporter:
    Lucian Holland
Vote (1)
Watch (3)

Dates

  • Created:
    Updated:

Time Tracking

Estimated:
2h
Original Estimate - 2 hours Original Estimate - 2 hours
Remaining:
1h 30m
Time Spent - 1 hour, 30 minutes Remaining Estimate - 1 hour, 30 minutes
Logged:
1h 30m
Time Spent - 1 hour, 30 minutes Remaining Estimate - 1 hour, 30 minutes