History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: XFIRE-920
Type: Bug Bug
Status: Resolved Resolved
Resolution: Fixed
Priority: Major Major
Assignee: Tomasz Sztelak
Reporter: Andreas Raquet
Votes: 0
Watchers: 1
Operations

If you were logged in you would be able to see more operations.
XFire

Http Proxy authentication not working

Created: 20/Mar/07 11:06 AM   Updated: 18/Apr/07 03:43 PM
Component/s: Core
Affects Version/s: 1.2.5
Fix Version/s: 1.2.6

Time Tracking:
Not Specified

File Attachments: 1. Java Source File CommonsHttpMessageSender.java (18 kb)
2. Text File proxyauth.patch (1 kb)



 Description  « Hide
http proxy authentication is not working if one uses a org.codehaus.xfire.client.Client. Username and password were provided as stated in the documentation, but they never arrive in the http message.

According to bug XFIRE-809, this should be fixed since 1.2.4, but it still does not work in 1.2.5. (I cannot reopen XFire-809)

After some debugging I found CommonsHttpMessageSender to be the culprit. In the createClient() method, it sets the proxy credentials as part of the client state. In the open() method - right after calling createClient() - it creates a new HttpState, overwriting the original client state that contained the proxy credentials.

To fix this, I moved the initialization of the proxy credentials from createClient() to open(), right where the http credentials are set. This setup works fine for me.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Greg Kempe - 16/Apr/07 05:05 AM
In addition, CommonsHttpMessageSender.getCredentials() unnecessarily sets preemptive authentication for regular (non-proxy) credentials, resulting in WARN log messages.

Patch against 1.2.5 attached.


Tomasz Sztelak - 18/Apr/07 03:43 PM
fixed in svn