|
|
|
[
Permlink
| « Hide
]
Dan Diephouse - 22/May/05 02:31 PM
Very cool Ralf. This is something I'd been meaning to do for a while. I'm not so sure about using JDOM to parse the xml though as that will add another dependency. We could use YOM instead (our MIT licensed XOM clone - see http://xom.nu
Thanks Ralf. I'll be taking a look at this later this week I think.
Just a comment or two on this while I'm looking at it:
1. There isn't a way to specify the implementation class 2. Its not possible to specify a different ServiceFactory. Granted I don't know a good way to do this though... Other than that it looks good added possibility to define impl of service
Just wanted you to know that I'm working on this right now (hopefully I can finish it before my phone starts ringing off the hook again). The reason it is taking a little bit is because there are some differences in HEAD compared to the version you wrote it against.
Dan,
could you please change the impl from private final static String CONFIG_FILE = "META-INF/xfire/services.xml"; to private final static String CONFIG_FILE = "services.xml"; The most of configurable java apis like log4j search for a file in the Ralf Ralf, it searches for that file on the classpath, not on the file system. So it would go in WEB-INF/classes/META-INF/xfire/services.xml. It just in a different location on the classpath... is that alright?
Dan, i saw the way it works and thought IMHO it would be more common if the file is not in a subfolder of the classpath.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||