History | Log In     View a printable version of the current page.  
Issue Details (XML | Word | Printable)

Key: XFIRE-77
Type: New Feature New Feature
Status: Closed Closed
Resolution: Fixed
Priority: Major Major
Assignee: Dan Diephouse
Reporter: Ralf Schaeftlein
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XFire

xfire simple configurator as plexus replacement

Created: 22/May/05 01:06 PM   Updated: 19/Jun/05 02:12 PM
Component/s: Core
Affects Version/s: 1.0-M4
Fix Version/s: 1.0-M5

Time Tracking:
Not Specified

File Attachments: 1. Java Archive File xfire-extension.jar (10 kb)
2. Java Archive File xfire-extension.v3.jar (5 kb)
3. Java Source File XFireConfigurableServlet.java (6 kb)



 Description  « Hide
I would like to contribute the attached code which is as Servlet similar to the XFireStandaloneServlet from xfire-plexus. We had problems inside Oracle ias 9.0.4 with the classloader stuff. The Servlet replace all plexus stuff incl. classworlds and need the services.xml inside the classpath e.g. Web-Inf/classes. It need jdom 1.0 and his dependend jars as xml parsing engine. I hadn't had the time to dig deeper into the problem but the effects was NoClassDefFound errors in places which didn't make sense. The problem was classworlds because without that jar we didn't get this errors in our code.

 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Dan Diephouse - 22/May/05 02:31 PM
Very cool Ralf. This is something I'd been meaning to do for a while. I'm not so sure about using JDOM to parse the xml though as that will add another dependency. We could use YOM instead (our MIT licensed XOM clone - see http://xom.nu for javadocs). I think it would be very good to get this in before M5 though! It would relieve some confusion too over plexus.

Ralf Schaeftlein - 23/May/05 04:34 PM
yom instead of jdom used

Dan Diephouse - 24/May/05 08:49 AM
Thanks Ralf. I'll be taking a look at this later this week I think.

Dan Diephouse - 25/May/05 02:19 PM
Just a comment or two on this while I'm looking at it:
1. There isn't a way to specify the implementation class
2. Its not possible to specify a different ServiceFactory. Granted I don't know a good way to do this though...

Other than that it looks good


Ralf Schaeftlein - 26/May/05 05:00 PM
added possibility to define impl of service

Dan Diephouse - 01/Jun/05 06:59 PM
Just wanted you to know that I'm working on this right now (hopefully I can finish it before my phone starts ringing off the hook again). The reason it is taking a little bit is because there are some differences in HEAD compared to the version you wrote it against.

Ralf Schaeftlein - 09/Jun/05 11:45 AM
Dan,

could you please change the impl from

private final static String CONFIG_FILE = "META-INF/xfire/services.xml";

to

private final static String CONFIG_FILE = "services.xml";

The most of configurable java apis like log4j search for a file in the
classpath. In web development are that kind of files in the Web-Inf/classes folder.
I would really appreaciate to have the xfire file in the same place.

Ralf


Dan Diephouse - 09/Jun/05 11:50 AM
Ralf, it searches for that file on the classpath, not on the file system. So it would go in WEB-INF/classes/META-INF/xfire/services.xml. It just in a different location on the classpath... is that alright?

Ralf Schaeftlein - 09/Jun/05 11:54 AM
Dan, i saw the way it works and thought IMHO it would be more common if the file is not in a subfolder of the classpath.