XFire

WSGen (xmlbeans) generates invalid code if illegal chars for variables are in the location

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Critical Critical
  • Resolution: Fixed
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.5
  • Component/s: Generator
  • Labels:
    None
  • Environment:
    JDK 1.5, Windows
  • Number of attachments :
    0

Description

After generating XMLBeans based stubs for our JIRA installation noticed errors in the generated code. Such as:

–
public JiraSoapServiceServiceClient() {
create0();
Endpoint jirasoapservice-v2EP = service0 .addEndpoint(new QName("http://.../jira/rpc/soap/jirasoapservice-v2", "jirasoapservice-v2"), new QName("http:/..../jira/rpc/soap/jirasoapservice-v2", "jirasoapservice-v2SoapBinding"), "http://.../jira/rpc/soap/jirasoapservice-v2");
endpoints.put(new QName("http:/.../jira/rpc/soap/jirasoapservice-v2", "jirasoapservice-v2"), jirasoapservice-v2EP);
–
Where the endpoint ends up with an embedded dash.

I assume the Endpoint var is taking it's name from the location or targetNamespace in the WSDL. Presumably the var generation needs to verify that it can use WSDL identifier directly as a java var.

Can be reproduced with the Codehaus jira's wsdl

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Barend Garvelink added a comment -

Consider this WSDL fragment:

<service name="example-service">
  <port name="example-port" binding="what:ever">
    <!-- blah blah -->
  </port>
</service>

The service name of "example-service" causes the code generator to fail at startup. When the service name taken care of (e.g. by using underscores), the code generator will do its magic, but the port name causes Java variable and method names with an embedded '-' sign to be generated, resulting in noncompileable code such as quoted in the original comment.

Show
Barend Garvelink added a comment - Consider this WSDL fragment: <service name= "example-service" > <port name= "example-port" binding= "what:ever" > <!-- blah blah --> </port> </service> The service name of "example-service" causes the code generator to fail at startup. When the service name taken care of (e.g. by using underscores), the code generator will do its magic, but the port name causes Java variable and method names with an embedded '-' sign to be generated, resulting in noncompileable code such as quoted in the original comment.
Hide
Permalink
Barend Garvelink added a comment -

I should probably add that this still affects version 1.2.4.

Show
Barend Garvelink added a comment - I should probably add that this still affects version 1.2.4.
Hide
Permalink
Barend Garvelink added a comment -

The message / part definitions suffer the same problem.

<message name="example-message">
		<part name="example-part" type="what:ever"/>
</message>

Also, while the Issue Title mensions xmlbeans, the issue applies to JAXB binding as well.

Show
Barend Garvelink added a comment - The message / part definitions suffer the same problem. <message name= "example-message" > <part name= "example-part" type= "what:ever" /> </message> Also, while the Issue Title mensions xmlbeans, the issue applies to JAXB binding as well.
Hide
Permalink
Dan Diephouse added a comment -

OK, thanks for reporting!

Show
Dan Diephouse added a comment - OK, thanks for reporting!
Hide
Permalink
Matthew added a comment -

I'm seeing the same issue with operation names in the port type:

<portType name="MyServices">
<operation name="My-Call">

Results in a service method named my-Call
I used v1.2.3 wsgen and jaxb

Show
Matthew added a comment - I'm seeing the same issue with operation names in the port type: <portType name="MyServices"> <operation name="My-Call"> Results in a service method named my-Call I used v1.2.3 wsgen and jaxb
Hide
Permalink
Tomasz Sztelak added a comment -

Some of this issues should be already fixed in svn, but i'll take a look again to make sure

Show
Tomasz Sztelak added a comment - Some of this issues should be already fixed in svn, but i'll take a look again to make sure
Hide
Permalink
Tomasz Sztelak added a comment -

Fixed in svn

Show
Tomasz Sztelak added a comment - Fixed in svn

People

  • Assignee:
    Tomasz Sztelak
    Reporter:
    Erich Oliphant
Vote (2)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: