XFire

XFireConfigurableServlet should shut down Spring Application Context beans

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.2
  • Component/s: Spring
  • Labels:
    None
  • Environment:
    Anyone using services.xml to configure additional spring beans
  • Number of attachments :
    1

Description

When the web application running XFire is reloaded, or shut down separately from the application server, there is a big problem in that the Spring beans are not also shut down properly. The Spring framework defines a shutdown hook that beans can implement, destroy() For instance, in our case our destroy() method shuts down extra threads that we have spawned and without this shutdown, these threads remain even though everything else gets removed.

XFireConfigurableServlet starts up the bean application context, but does not currently shut it down when servlet.destroy is called.

I am attaching the proposed patch.

Activity

Hide
Dan Diephouse added a comment -

Thanks Jeff. We'll apply this.

Show
Dan Diephouse added a comment - Thanks Jeff. We'll apply this.
Hide
Dan Diephouse added a comment -

Just applied this to SVN. Thanks again.

Show
Dan Diephouse added a comment - Just applied this to SVN. Thanks again.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: