[#XFIRE-646] two simple extensibility patches for XFireServletController and XFireServletChannel

XFire

two simple extensibility patches for XFireServletController and XFireServletChannel

Created: 15/Sep/06 04:30 PM Updated: 30/Sep/06 09:57 PM

Component/s:

Core

Affects Version/s:

1.2.1

Fix Version/s:

1.2.2

Time Tracking:

Not Specified

File Attachments:

patches.zip (1 kb)
2.

xfire.patch (5 kb)

Description

« Hide

Attached is a ZIP file containing two diff files – one each for XFireServletController.java and XFireServletChannel.java. The patches are very simple refactorings to make these two classes easier to extend to add custom behavior. I am working on adding XML Fast Infoset support to XFire and these patches will make that easier. I will submit more patches if the first are applied and as I have time.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Tomasz Sztelak - 19/Sep/06 05:57 AM

As i remember Fast Infoset works fine with XFire.

[ Permlink | « Hide ]

Levi Purvis - 19/Sep/06 07:13 AM

At best, FI can be turned on for all requests by changing the StAX factories - but the Content-Type headers will not match. XFire does not handle per-request negotiation of FI using the Accept and Content-Type headers. Currently, it's just not usable without having total control of the client, server, and all proxies in-between (some proxies and web servers might mangle the stream if Content-Type is not set properly). See the following link for information on how Sun handles it:

http://java.sun.com/webservices/docs/1.6/jaxrpc/fastinfoset/manual.html

[ Permlink | « Hide ]

Dan Diephouse - 19/Sep/06 10:43 AM

Thanks for the information, we definitely want to support this and will look at getting your patches integrated.

[ Permlink | « Hide ]

Dan Diephouse - 29/Sep/06 01:12 PM

Hi Levi - these are in a really weird patch format. Any chance you can just run "svn diff > xfire.patch" and give us the output of that?

[ Permlink | « Hide ]

Levi Purvis - 29/Sep/06 03:33 PM

Here's the svn diff...

[ Permlink | « Hide ]

Dan Diephouse - 30/Sep/06 09:57 PM

Thanks, this has been applied. Any ideas how to make this easier out of the box?