XFire

two simple extensibility patches for XFireServletController and XFireServletChannel

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.2.1
  • Fix Version/s: 1.2.2
  • Component/s: Core
  • Labels:
    None
  • Number of attachments :
    2

Description

Attached is a ZIP file containing two diff files – one each for XFireServletController.java and XFireServletChannel.java. The patches are very simple refactorings to make these two classes easier to extend to add custom behavior. I am working on adding XML Fast Infoset support to XFire and these patches will make that easier. I will submit more patches if the first are applied and as I have time.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tomasz Sztelak added a comment -

As i remember Fast Infoset works fine with XFire.

Show
Tomasz Sztelak added a comment - As i remember Fast Infoset works fine with XFire.
Hide
Permalink
Levi Purvis added a comment -

At best, FI can be turned on for all requests by changing the StAX factories - but the Content-Type headers will not match. XFire does not handle per-request negotiation of FI using the Accept and Content-Type headers. Currently, it's just not usable without having total control of the client, server, and all proxies in-between (some proxies and web servers might mangle the stream if Content-Type is not set properly). See the following link for information on how Sun handles it:

http://java.sun.com/webservices/docs/1.6/jaxrpc/fastinfoset/manual.html

Show
Levi Purvis added a comment - At best, FI can be turned on for all requests by changing the StAX factories - but the Content-Type headers will not match. XFire does not handle per-request negotiation of FI using the Accept and Content-Type headers. Currently, it's just not usable without having total control of the client, server, and all proxies in-between (some proxies and web servers might mangle the stream if Content-Type is not set properly). See the following link for information on how Sun handles it: http://java.sun.com/webservices/docs/1.6/jaxrpc/fastinfoset/manual.html
Hide
Permalink
Dan Diephouse added a comment -

Thanks for the information, we definitely want to support this and will look at getting your patches integrated.

Show
Dan Diephouse added a comment - Thanks for the information, we definitely want to support this and will look at getting your patches integrated.
Hide
Permalink
Dan Diephouse added a comment -

Hi Levi - these are in a really weird patch format. Any chance you can just run "svn diff > xfire.patch" and give us the output of that?

Show
Dan Diephouse added a comment - Hi Levi - these are in a really weird patch format. Any chance you can just run "svn diff > xfire.patch" and give us the output of that?
Hide
Permalink
Levi Purvis added a comment -

Here's the svn diff...

Show
Levi Purvis added a comment - Here's the svn diff...
Hide
Permalink
Dan Diephouse added a comment -

Thanks, this has been applied. Any ideas how to make this easier out of the box?

Show
Dan Diephouse added a comment - Thanks, this has been applied. Any ideas how to make this easier out of the box?

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.