XFire

XFireClientFactoryBean doesn't use URIResolver.

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.2.1
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Classpath and filesystem wsdls don't work with the XFireClientFactoryBean because it doesn't use URIResolver.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael Vorburger added a comment -

Dan - I just looked at this... tried the JAR and SVN update. Comments:

That resolver.getURI().toURL() in XFireClientFactoryBean is prone to NPE (two maybe?) - in fact its the first thing that happened to me... when using a "hello.wsdl" that looked relative, but could not be found. How about a clear error message in that case?

Unfortunately, even when using a "/hello.wsdl" I didn't seem to work, but here it failed with: Could not find resource '/hello.wsdl' relative to '', although I do believe I have that on the classpath... weired. A simple getClass().getResource("/hello.wsdl") find it, but that Resolver (whew!) does not.

If it would work, an "interesting" corner case to test could be whether you could specify a WSDL that imports a XSD - that would require the base thing to be set correctly.

Anyway. Not a burning issue for me, but I thought I'd provide some feedback as I just briefly tested this.

Show
Michael Vorburger added a comment - Dan - I just looked at this... tried the JAR and SVN update. Comments: That resolver.getURI().toURL() in XFireClientFactoryBean is prone to NPE (two maybe?) - in fact its the first thing that happened to me... when using a "hello.wsdl" that looked relative, but could not be found. How about a clear error message in that case? Unfortunately, even when using a "/hello.wsdl" I didn't seem to work, but here it failed with: Could not find resource '/hello.wsdl' relative to '', although I do believe I have that on the classpath... weired. A simple getClass().getResource("/hello.wsdl") find it, but that Resolver (whew!) does not. If it would work, an "interesting" corner case to test could be whether you could specify a WSDL that imports a XSD - that would require the base thing to be set correctly. Anyway. Not a burning issue for me, but I thought I'd provide some feedback as I just briefly tested this.
Hide
Permalink
Dan Diephouse added a comment -

Good point on the NPE and the error message. I'll get that improved.

I'm not sure whats happening on the classpath resource. I'll dig into it more.

Show
Dan Diephouse added a comment - Good point on the NPE and the error message. I'll get that improved. I'm not sure whats happening on the classpath resource. I'll dig into it more.
Hide
Permalink
Dan Diephouse added a comment -

OK, I even added a unit test for classpath resources and things work great. Additionally I added some logic to support "classpath:foo.wsdl" urls. You can give this build a whirl, but I'm pretty sure that its something with your environment if this doesn't work:

http://snapshots.repository.codehaus.org/org/codehaus/xfire/xfire-all/1.2-SNAPSHOT/xfire-all-1.2-20060901.201314-13.jar

Show
Dan Diephouse added a comment - OK, I even added a unit test for classpath resources and things work great. Additionally I added some logic to support "classpath:foo.wsdl" urls. You can give this build a whirl, but I'm pretty sure that its something with your environment if this doesn't work: http://snapshots.repository.codehaus.org/org/codehaus/xfire/xfire-all/1.2-SNAPSHOT/xfire-all-1.2-20060901.201314-13.jar

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4.3#663-r165197) | Report a problem
Powered by a free Atlassian JIRA open source license for Codehaus. Try JIRA - bug tracking software for your team.