Details
-
Type:
Bug
-
Status:
Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 1.2-RC
-
Fix Version/s: 1.2.1
-
Component/s: Aegis Module
-
Labels:None
-
Environment:Using Java5 annotations and thus Java5TypeCreator.
-
Number of attachments :
Description
When attempting to provide concrete implementations of interfaces, as described in the last section of http://xfire.codehaus.org/Aegis+Binding, the service picked up the override types correctly. However, when it comes to writing out the types, a bean that contains a List (say) of the overridden interface wasn't overriding these types correctly. What happened was that the outer bean would call AegisBindingProvider.getWriteType(), passing in the List itself. Since this function doesn't inspect the component type of the list, it wasn't possible at this stage for it to notice the types that should be overridden. So off we go into CollectionType.writeObject(), and here it assumes that the Type of all the elements in the list is the same as the declared type.
This is incorrect; my bean had a List<IDataColumn>, so actual members of the List may be SQLColumns, DataAggregateColumns, etc. What was needed was to call AegisBindingProvider.getWriteType(), passing in each element of the list. As it turns out, the superclass ArrayType already did the right thing with its writeValue() method, so the solution seems to be to defer the actual write to this method. I attach a patch that does this, and worked perfectly for me.
Activity
Thankyou! 8 minutes is what I'd call excellent response time 
I tried the snapshot jar and something has changed, as the previous ClassCastException from CollectionType has changed to this:
2006-09-04 17:57:46,242 [http-8180-Processor4] DEBUG org.codehaus.xfire.handler.HandlerPipeline - Invoking handler org.codehaus.xfire.handler.OutMessageSender i
n phase send
2006-09-04 17:57:46,266 [http-8180-Processor4] ERROR org.codehaus.xfire.service.binding.PostInvocationHandler - java.lang.NullPointerException
2006-09-04 17:57:46,269 [http-8180-Processor4] ERROR org.codehaus.xfire.handler.DefaultFaultHandler - Fault occurred!
java.lang.NullPointerException
at org.codehaus.xfire.aegis.type.basic.ObjectType.determineType(ObjectType.java:192)
at org.codehaus.xfire.aegis.type.basic.ObjectType.writeObject(ObjectType.java:165)
at org.codehaus.xfire.aegis.type.basic.ArrayType.writeValue(ArrayType.java:293)
at org.codehaus.xfire.aegis.type.collection.CollectionType.writeObject(CollectionType.java:103)
at org.codehaus.xfire.aegis.type.basic.BeanType.writeObject(BeanType.java:413)
at org.codehaus.xfire.aegis.AegisBindingProvider.writeParameter(AegisBindingProvider.java:194)
at org.codehaus.xfire.service.binding.AbstractBinding.writeParameter(AbstractBinding.java:273)
at org.codehaus.xfire.service.binding.WrappedBinding.writeMessage(WrappedBinding.java:89)
at org.codehaus.xfire.soap.SoapSerializer.writeMessage(SoapSerializer.java:80)
Its your lucky day I guess - If you're using java 1.4 - did you configure your collections like the bottom of this page says:
http://xfire.codehaus.org/Mapping+collections
Or are you using Java 5? If they're java5 collections, xfire should figure them out autmotically.
I'm marking this as a duplicate of
XFIRE-545, but I will be applying this patch. Thanks!