java.lang.ArrayIndexOutOfBoundsException when marshalling byte array

Bruce Li added a comment - 18/Jul/06 4:09 PM To debug Xfire with source code of version 1.1.2, the problem happens when marshalling byte array. The following is the segment of source code from org.codehaus.xfire.aegis.type.basic.Base64Type that causes exception: Xfire v1.1.2: org.codehaus.xfire.aegis.type.basic.Base64Type public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = reader.getTextLength(); char[] myBuffer = new char [length] ; for (int sourceStart = 0;; sourceStart += length) { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); if (nCopied < length) break; } ... } When debug, the length is the byte array size after the call of "reader.getTextLength()". And then, "nCopied" equal "length" after "getTextCharacters" call. if (nCopied < length) // Wrong!!! (nCopied == length) and it should break break; Because of above comparison expression, it goes to the next loop, it definitely throw "java.lang.ArrayIndexOutOfBoundsException" running at "reader.getTextCharacters(sourceStart, myBuffer, 0, length)" Comparing the segment code of Xfire v1.0, it doesn't have such bug as following: Xfire v1.0: org.codehaus.xfire.aegis.type.basic.Base64Type public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = 1024; char[] myBuffer = new char [length] ; for (int sourceStart = 0;; sourceStart += length) { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); if (nCopied < length) break; } ... } Obviously, the logic of the segment of code is changed from v1.0 to v1.1. I could fix it as following: public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = reader.getTextLength(); char[] myBuffer = new char [length] ; // for (int sourceStart = 0;; sourceStart += length) // { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); // if (nCopied < length) // break; //} ... } However, I finally just fix it as following for temporary use: public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = reader.getTextLength(); char[] myBuffer = new char [length] ; for (int sourceStart = 0;; sourceStart += length) { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); if (nCopied <= length) // Change "<" to "<=" break; } ... }

Christoph Sturm added a comment - 18/Jul/06 4:10 PM from the stacktrace it looks like you are using the stax reference implementation. could you try if it works if you use woodstox instead?

Christoph Sturm added a comment - 18/Jul/06 4:22 PM disregard my last comment, which i wrote while you wrote yours thanks for looking into this, do you have a testcase too maybe?

Bruce Li added a comment - 18/Jul/06 4:48 PM It's my pleasure. I have to copy/paste again since the "/n" is gone. Obviously, the logic of the segment of code is changed from v1.0 to v1.1. I could fix it as following: public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = reader.getTextLength(); char[] myBuffer = new char [length] ; // for (int sourceStart = 0;; sourceStart += length) // { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); // if (nCopied < length) // break; //} ... } However, I finally just fix it as following for temporary use: public Object readObject(MessageReader mreader, MessageContext context) throws XfireFault { ... int length = reader.getTextLength(); char[] myBuffer = new char [length] ; for (int sourceStart = 0;; sourceStart += length) { int nCopied = reader.getTextCharacters(sourceStart, myBuffer, 0, length); Base64.decode(myBuffer, 0, nCopied, bos); if (nCopied <= length) // Change "<" to "<=" break; } ... }

Bruce Li added a comment - 18/Jul/06 5:00 PM I have the fake test case as following: .NET platform (C# Client) { ... RemoteAdapter.JddServiceWsAdapter jddAdapter = new RemoteJddAdapter.JddServiceWsAdapter(); zipName = "D:\\Test MyTarget.zip"; zipBytes = getData(zipName, 204800); try { string tasks = jddAdapter.doTask(zipName,zipBytes,...) } catch(Exception e) { MessageBox.Show( "JDD Adapter exception thrown: " + e.Message, "", MessageBoxButtons.OK, MessageBoxIcon.Warning); return; } ... Java Platform (Server): public String doTask(String zipName,byte[] zipBytes,...) { ... } The web server security uses "aegis"

Bruce Li added a comment - 19/Jul/06 9:34 AM Which is official way to contribute my fix?