Issue Details (XML | Word | Printable)

Key: XFIRE-423
Type: Improvement Improvement
Status: Closed Closed
Resolution: Fixed
Priority: Minor Minor
Assignee: Tomasz Sztelak
Reporter: Marc Logemann
Votes: 0
Watchers: 0
Operations

If you were logged in you would be able to see more operations.
XFire

rename customEditorConfigurer in customEditors.xml

Created: 25/May/06 12:28 PM   Updated: 25/Jun/06 05:35 PM
Component/s: Spring
Affects Version/s: 1.1
Fix Version/s: 1.1.2

Time Tracking:
Not Specified


 Description  « Hide
It would be better to rename "customEditorConfigurer" bean to something like "xfireCustomEditorConfigurer". This way xFire doesnt overrode editors users had created in the Spring context before. Because the spring documentation names "customEditorConfigurer" as an example for custom editors, its likely that a lot of Spring applications have a bean with that name.

The result is that if xFire context is loaded at the end of the bootstrapping, user editors gets overridden, most likely resulting in a application startup failure.



 All   Comments   Work Log   Change History      Sort Order: Ascending order - Click to sort in descending order
Marc Logemann added a comment - 25/May/06 12:30 PM
When xFire moves to Spring 2.0 support, Namespace should be used. But this would of course break spring 1.x support. Just a note.

Dan Diephouse added a comment - 24/Jun/06 05:35 PM
Maybe we can just call it xfire.customEditors

Dan Diephouse added a comment - 25/Jun/06 05:35 PM
Fixed in SVN. Thanks Marc!