XFire

ThreadLocals not cleared in XFireServletController

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 1.0
  • Fix Version/s: 1.1
  • Component/s: Core
  • Labels:
    None
  • Environment:
    Windows XP, Sun Java 5, Tomcat 4
  • Number of attachments :
    0

Description

XFireServletController.doService can set the ThreadLocal 'requests' and 'responses' members, but neglect to clear them before returning. This can be a source of confusion to the affected thread. For example, the thread may be subsequently assigned (by a frugal servlet container) to process an unrelated request, at which point the ThreadLocal request and response may have been (frugally) allocated to other uses unrelated to this thread's current work. Havoc may ensue.

Please take greater care to clear these ThreadLocal members before exiting doService.

Activity

Hide
Dan Diephouse added a comment -

Sure enough, it only happens when we generate WSDL, but I just fixed this in SVN.

Show
Dan Diephouse added a comment - Sure enough, it only happens when we generate WSDL, but I just fixed this in SVN.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: