XFire

Excluded methods mechanism used in the ObjectServiceFactory doesn't seem to work

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Won't Fix
  • Affects Version/s: 1.1-beta-1
  • Fix Version/s: None
  • Component/s: Core
  • Labels:
    None
  • Number of attachments :
    0

Description

When ObjectServiceFactory creates its operations it seems to incorrectly evaluated which methods to exclude. the current method -

protected boolean isValidMethod(final Method method)

{ if(ignoredClasses.contains(method.getDeclaringClass().getName())) return false; final int modifiers = method.getModifiers(); return Modifier.isPublic(modifiers) && !Modifier.isStatic(modifiers); }

Doesn't work for custom ignorred classes where the ignorred class is an interface. In this scenario the method.getDeclaringClass() does not return the Inteface name, but the FQN of the service class. We're currently using a modified ObjectFactory that just compares the method names.

Activity

rossmason rossmason made changes -
Field Original Value New Value
Status Open [ 1 ] Closed [ 6 ]
Resolution Won't Fix [ 2 ]

People

  • Assignee:
    Dan Diephouse
    Reporter:
    rossmason rossmason
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: