XFire

Ambigious use of attribute "type"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0
  • Component/s: Aegis Module
  • Labels:
    None
  • Number of attachments :
    0

Description

The attribute "type" of element <parameter> is used to differ between overloaded methods. However, in XMLTypeCreator.readMetadata, the attribute is interpreted as a subclass of Type. This results in a ClassCastException in AbstractTypeCreator.createUserType(AbstractTypeCreator.java:133).

Fix: Remove XMLTypeCreator.setType, and register custom Type classes in services.xml or programmatic.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Dan Diephouse added a comment -

the type attribute is to specify a custom Type class, not specify the type name, so classes should be a subclass of Type. The typeName attribute specifies the name of the type you want pull from the TypeMapping (via typeMapping.getType(qName)).

So I guess I don't see the issue here...

Show
Dan Diephouse added a comment - the type attribute is to specify a custom Type class, not specify the type name, so classes should be a subclass of Type. The typeName attribute specifies the name of the type you want pull from the TypeMapping (via typeMapping.getType(qName)). So I guess I don't see the issue here...
Hide
Permalink
Øyvind Matheson Wergeland added a comment -

Not according to http://xfire.codehaus.org/Mapping+collections?nocache where <parameter index="2" type="boolean"/> is used to find the most specific method map for a method.

Show
Øyvind Matheson Wergeland added a comment - Not according to http://xfire.codehaus.org/Mapping+collections?nocache where <parameter index="2" type="boolean"/> is used to find the most specific method map for a method.
Hide
Permalink
Dan Diephouse added a comment -

I will have to fix the documentation... Thanks.

Show
Dan Diephouse added a comment - I will have to fix the documentation... Thanks.
Hide
Permalink
Dan Diephouse added a comment -

OK, I see what you really mean now. I changed the documentation and the source code so we use the "class" attribute when trying to locate the correct method to apply the properties to. I'll try to get new snapshots by tomorrow.

Show
Dan Diephouse added a comment - OK, I see what you really mean now. I changed the documentation and the source code so we use the "class" attribute when trying to locate the correct method to apply the properties to. I'll try to get new snapshots by tomorrow.
Hide
Permalink
Øyvind Matheson Wergeland added a comment -

Excellent. Works perfectly out of CVS at least.

Show
Øyvind Matheson Wergeland added a comment - Excellent. Works perfectly out of CVS at least.

People

  • Assignee:
    Dan Diephouse
    Reporter:
    Øyvind Matheson Wergeland
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: