[#XFIRE-274] Ambigious use of attribute "type"

XFire

Ambigious use of attribute "type"

Created: 20/Feb/06 05:53 AM Updated: 22/Feb/06 03:58 AM

Component/s:

Aegis Module

Affects Version/s:

None

Fix Version/s:

1.0

Time Tracking:

Not Specified

Description

« Hide

The attribute "type" of element <parameter> is used to differ between overloaded methods. However, in XMLTypeCreator.readMetadata, the attribute is interpreted as a subclass of Type. This results in a ClassCastException in AbstractTypeCreator.createUserType(AbstractTypeCreator.java:133).

Fix: Remove XMLTypeCreator.setType, and register custom Type classes in services.xml or programmatic.

All

Comments

Work Log

Change History

Sort Order:

Ascending order - Click to sort in descending order

[ Permlink | « Hide ]

Dan Diephouse - 20/Feb/06 08:01 AM

the type attribute is to specify a custom Type class, not specify the type name, so classes should be a subclass of Type. The typeName attribute specifies the name of the type you want pull from the TypeMapping (via typeMapping.getType(qName)).

So I guess I don't see the issue here...

[ Permlink | « Hide ]

Øyvind Matheson Wergeland - 21/Feb/06 01:05 AM

Not according to http://xfire.codehaus.org/Mapping+collections?nocache where <parameter index="2" type="boolean"/> is used to find the most specific method map for a method.

[ Permlink | « Hide ]

Dan Diephouse - 21/Feb/06 09:22 AM

I will have to fix the documentation... Thanks.

[ Permlink | « Hide ]

Dan Diephouse - 21/Feb/06 07:24 PM

OK, I see what you really mean now. I changed the documentation and the source code so we use the "class" attribute when trying to locate the correct method to apply the properties to. I'll try to get new snapshots by tomorrow.

[ Permlink | « Hide ]

Øyvind Matheson Wergeland - 22/Feb/06 03:58 AM

Excellent. Works perfectly out of CVS at least.