XFire

Aegis mapping files not read

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.1
  • Component/s: Aegis Module
  • Labels:
    None
  • Number of attachments :
    2

Description

For subclasses without a mapping file, mappings for superclasses are ignored. A workaround is to provide mapping files for such subclasses.

Mappings files for keyType and componentType of maps are also not read.
Investigation shows that XMLTypeCreator.createMapType delegates to nextCreator, which is a DefaultTypeCreator, since there are no mapping file for java.util.Map. DefaultTypeCreator then creates the keyType and componentType without bothering to check for mapping files.

A patch is included for the latter case.

  1. Text File
    XMLTypeCreator.java.patch
    05/Apr/06 12:39 PM
    1 kB
    Øyvind Matheson Wergeland
  2. Text File
    XMLTypeCreator.java.patch
    31/Jan/06 6:05 AM
    1 kB
    Øyvind Matheson Wergeland

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Mika Goeckel added a comment -

Patch applied.

Show
Mika Goeckel added a comment - Patch applied.
Hide
Permalink
Mika Goeckel added a comment -

Oops.. only the second issue is in fact resolved. I look into the first one now.

Show
Mika Goeckel added a comment - Oops.. only the second issue is in fact resolved. I look into the first one now.
Hide
Permalink
Mika Goeckel added a comment -

Fixed parent searching for mapping files.

Show
Mika Goeckel added a comment - Fixed parent searching for mapping files.
Hide
Permalink
Øyvind Matheson Wergeland added a comment -

Mapping files for implemented/extended interfaces should also be read.
I am attatching a patch for this.

Show
Øyvind Matheson Wergeland added a comment - Mapping files for implemented/extended interfaces should also be read. I am attatching a patch for this.
Hide
Permalink
Øyvind Matheson Wergeland added a comment -

Patch to read mapping files for implemented/extended interfaces.
Also contains a minor update.
Based on the 1.0 release.

Show
Øyvind Matheson Wergeland added a comment - Patch to read mapping files for implemented/extended interfaces. Also contains a minor update. Based on the 1.0 release.
Hide
Permalink
Dan Diephouse added a comment -

Was this ever integrated?

Show
Dan Diephouse added a comment - Was this ever integrated?
Hide
Permalink
Mika Goeckel added a comment -

Not fully. I tried to do it quickly but actually need a closer look.

Show
Mika Goeckel added a comment - Not fully. I tried to do it quickly but actually need a closer look.
Hide
Permalink
Mika Goeckel added a comment -

Added testcases and the patch.

Show
Mika Goeckel added a comment - Added testcases and the patch.

People

  • Assignee:
    Mika Goeckel
    Reporter:
    Øyvind Matheson Wergeland
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: