hibernate join table property cannot be configured

Hello All,

I am also facing the same issue. Please read through the description below.
##################
From: Chitragar, Vinayak
Sent: Friday, October 21, 2005 11:36 AM
To: 'xdoclet-plugins-interest@lists.sourceforge.net'
Subject: Join Tag - One2Many with table Per Concrete Class

Hello All,

I am trying to implement a construct which uses Interfaces to define 1:* association between an object and an interface which has more than one subclasses.

The class associations and hibernate mappings that works is given below. However, as XDoclet2's tag - hibernate.join - is a class level tag, I am not able to generate the hibernate mapping file using XDoclet2.

Class Associations -

1. P associated with interface X.
2. X is implemented by classes Z & Z1.

(Could not include class dia due to mail size restriction)

Please review this and let me know if there is an alternative available.

<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC
"-//Hibernate/Hibernate Mapping DTD//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping package="one2many">
<class name="P" table="PTEST">
<id name="id" column="P_ID" type="java.lang.Long">
<generator class="increment"/>
</id>
<set name="xs" table="P_XTEST">
<key column="P_ID"/>
<many-to-any meta-type="string" id-type="long">
<meta-value value="Z" class="Z"/>
<meta-value value="Z1" class="Z1"/>
<column name="X_CLASSNAME"/>
<column name="X_ID"/>
</many-to-any>
</set>
</class>
</hibernate-mapping>

<?xml version="1.0"?>
<!DOCTYPE hibernate-mapping PUBLIC
"-//Hibernate/Hibernate Mapping DTD//EN"
"http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">
<hibernate-mapping package="one2many">
<class name="Z1" table="Z1TEST">
<id name="id" column="Z1_ID" type="java.lang.Long">
<generator class="increment"/>
</id>
<join table="P_XTEST" inverse="true">
<key column="X_ID"/>
<many-to-one name="p" column="P_ID"/>
</join>
</class>
</hibernate-mapping>

This class diagram provides context for the example in the comment.

I had the same problems with the join tag, in that the subclass's properties weren't appearing within the subclass's join tag and the join key was not being generated (i.e. it was generated as an empty <key/> tag).

Rather than waiting for a fix, I decided to fix/enhance Xdoclet2 myself in version 2-1.0.1:

What I did first was add a new @hibernate property called hibernate.join-key (this property was referred to in the Join.jelly file, but didn't have an entry in the TagLibrary class so it wasn't recognised by the parser). Secondly, I modified the Subclass.jelly and Join.jelly files to
a. process <property> tags within the join
b. if the subclass contains a <join>, then do not process the <property> tags for that subclass (but do for it's subclasses)

The files I've changed are:
org/xdoclet/plugin/hibernate/Join.jelly
org/xdoclet/plugin/hibernate/Subclass.jelly
org/xdoclet/plugin/hibernate/qtags/TagLibrary.java

I've also created the following 2 new classes:
org/xdoclet/plugin/hibernate/HibernateJoinKeyTag.java
org/xdoclet/plugin/hibernate/HibernateJoinKeyTagImpl.java

I've tested the fix by comparing my handcrafted Hibernate mapping file against the file generated by my modified Xdoclet2 and they are exactly the same.

I will do a comparison of the code I've changed against the latest 1.0.2 plugins codebase and submit the files list above into the project.

Julian

Hello Julian,

Can you please post a comment once the files have been added?

thanks,
^_ Vinayak

Hi julian i am also trying the same
can you post the changes in detail in which java file you made changes?
— for following file –
org/xdoclet/plugin/hibernate/HibernateJoinKeyTag.java
org/xdoclet/plugin/hibernate/HibernateJoinKeyTagImpl.java

also , your fix solves the problem mentioned in the first comment ?
that , XDoclet2 cannot able to generate the property tag inside the join tag ,
– as given in the first description of the issue--
xdoclet always adds the property
tag to the class tag that surrounds the join tag. Looking at the
Join.jelly file it looks like it is not possible to add properties
to the join table tag, which makes the join tag impossible to use
with xdoclet 2, or did i miss something ?

is there any one looking for this issue ? i have another one issue also
Julian ,
i have tried following for generating join

my finding at this time are
in join.jelly , i found that , there is no logic fot grouping the tags which can come under join
as per hibernate3.0 DTD we can have 6 tags common to class & join tags
eg. <property>,<any> ect can appear in class as well as join rt?
so i added one more property named "join-name" in all this 6 common tags

so you need to put it like following in ur class , if you want that element to be generated inside <join>..... </join>

/**

• @hibernate.class table="ZTEST"
• @hibernate.join table="P_XTEST" join-name="testJoin"
• @hibernate.join-key column="ABC" join-name="testJoin"
• @hibernate.join table="P1_XTEST" join-name="testJoin1"
• @hibernate.join-key column="ABC1" join-name="testJoin1"
  *
  */

public class Z implements X {

private Long id;
private P p;
private Integer i;

......

...
/**

• @hibernate.many-to-one
• column="P_ID"
• join-name="testJoin"
  */

public P getP()

..
..
..
..
..
}

the changes were done in many files
but this will ensure that the tags which contain join-name="XXX" will get generated in that join

here i have problem in scripting
i was able to generate this logic for key as shown above but could not able to do same for other 5 tags common to class & join

from above the generated join mapping will look like following

<join table="P_XTEST">
<key column="ABC"/>
</join>
<join table="P1_XTEST">
<key column="ABC1"/>
</join>

here i have expected to get <many-to-one> also inside the join as in above example i have added join-name="testjoin" to it ,
but it is not getting generated

How about this issue ?

I think this one is really critical. Hope anyone find find a solution soon since xdoclet2 seems very unuseless for me without being able to map many-to-many assiciations correctly using join-tables

Why do not you look into issue yourself? There not as many
active commiters as I would like, and my (free) time is kind of limited.

So issues with attached patches come first. To fix this issue I will need
to look nito this in depth.

Hi,
I've added at patch to this issue (patch.txt) which is a first step in including this functionality. The patch adds the missing @hibernate.join-key functionality and contains a test case.

Can anybody tell me where to add the support for relationships (like a many-to-one) through a join table in xdoclet2. I'd appreciate any hints since I'd like to enable that hibernate feature in xdoclet2.

Cheers,
mike

Please note that the patch.txt file was an old one conatianing some serious bugs that dont compile... I will provide an updated one ASAP

please remove patch.txt and use this (patch_new.txt) instead!

Patch aplied , snapshot deployed. Thanks.

Best place to ask questions would be on xdoclet-plugin-interest mailing list

Konstantin, thanks for applying the bug. However there is still work to be done in order to be able to map a many-to-one relationship through a join table with xdoclet.

Currently I'm figuring out how to apply this. I'll propably write some questions to the dev mailing list tonight.

cheers,
mike

go on...

to girish sathe
hi, i also try to implement 'join-name' to sub tags of join. So far, i added join-name to property tag which is the most common use tag inside join, it works well.

I create a patch to let join support property subtag. But I don't how to upload this patch It seems only thing i can do here is post a comment.
Here is the test case I include in my patch, show how @hibernate.join tags works after using this patch.

//JoinMapping.java

package org.xdoclet.plugin.hibernate.pojo;

/**

• @author Ryan Ye
• @hibernate.class table="join_parent_table"
• @hibernate.join name="testJoin" table="join_table"
• @hibernate.join-key column="join_key_column"
  */
  public class JoinMapping {

/**

• @hibernate.id generator-class="assigned"
  */
  public Integer getId() { return null; }
  
  /**
  * @hibernate.property column="join_property_column" join-name="testJoin"
  */
  public String getJoinProperty(){ return null; }

}

this java src will generate
//JoinMapping.hbm.xml
<?xml version="1.0" encoding="ISO-8859-1"?>
<!DOCTYPE hibernate-mapping PUBLIC "-//Hibernate/Hibernate Mapping DTD 3.0//EN" "http://hibernate.sourceforge.net/hibernate-mapping-3.0.dtd">

<hibernate-mapping>
<class table="join_parent_table" name="org.xdoclet.plugin.hibernate.pojo.JoinMapping">
<id access="property" name="id">
<generator class="assigned"/>
</id>
<join table="join_table">
<key column="join_key_column"/>
<property name="joinProperty" access="property" column="join_property_column"/>
</join>
</class>
</hibernate-mapping>

You may use "manage attachments" link somewhere near the top.
However, as this issue is already fixed, it would be better to open another
( and link to this one if necessary )

so your patch can be reviewed separately.

Thx Konstantin, I've created an new issue for this http://jira.codehaus.org/browse/XDP-213