XDoclet 2 Plugins

Validating generated metafiles using dtd

Details

  • Type: New Feature New Feature
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Number of attachments :
    0

Description

Use-case: Several plugins can generate metadata (xml-descriptors) for several versions of product. For example hibernate plugin can generate both H2 and H3 version of mappings which are differs a lot. Hibernate plugin uses superset of tags so nobody restricts users to use @hibernate.jsc-cache for H3 mapping generation. In this case we take incorrect mapping file.

So my proposal is automatically validate generated metadata file using dtd. This allows us reduce number of errors on deployment time.

Applicable for any xml-generated plugin (hibernate, struts, ...)

Of cource this feature should be customizable. In property can be called "validate" (Is it ok??)

maven.xdoclet.0.hibernate.destdir=$

{maven.build.dest}

/$

{package}

maven.xdoclet.0.hibernate.version=3.0
maven.xdoclet.0.hibernate.validate=true

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Konstantin Pribluda added a comment -

I think ( at least ) in hibernate case offending tags shall not be used
in generation of DD for different versions. But validation is nice feature.

It could reside in generama/xdoclet combo

Show
Konstantin Pribluda added a comment - I think ( at least ) in hibernate case offending tags shall not be used in generation of DD for different versions. But validation is nice feature. It could reside in generama/xdoclet combo
Hide
Permalink
Anatol Pomozov added a comment -

>> I think ( at least ) in hibernate case offending tags shall not be used.
Quick and dirty way to do it use if statements in .jelly scripts. Something like this
<c:if test="$

{plugin.is20Version}

">
<jcs-cache blah="blah"
</c:if>

But I dont like such way because scripts quickly become a mess. I think better to it using qtags.

Something like this
/**

  • @qtags.using expression="plugin.version == '2.0'"
    */
    getAttribute1()

where expression (OGNL, groovy, ...) returns bool value. And if it true then use tag/parameter otherwise print warning to screen.

Show
Anatol Pomozov added a comment - >> I think ( at least ) in hibernate case offending tags shall not be used. Quick and dirty way to do it use if statements in .jelly scripts. Something like this <c:if test="$ {plugin.is20Version} "> <jcs-cache blah="blah" </c:if> But I dont like such way because scripts quickly become a mess. I think better to it using qtags. Something like this /** @qtags.using expression="plugin.version == '2.0'" */ getAttribute1() where expression (OGNL, groovy, ...) returns bool value. And if it true then use tag/parameter otherwise print warning to screen.
Hide
Permalink
Konstantin Pribluda added a comment -

You propose to move mess from jelly template to qtags implementation?
I would prefer to avoid mess altogether.

As far as I see, there are changes in indivudual property mappings?
Since we dispatch properties via plugin based on their name, we could as well
dispatch to different template based on selected dtd version.

or even have 2 separate plugins, where one is hardwired to 2.0 and another to 3.0

Show
Konstantin Pribluda added a comment - You propose to move mess from jelly template to qtags implementation? I would prefer to avoid mess altogether. As far as I see, there are changes in indivudual property mappings? Since we dispatch properties via plugin based on their name, we could as well dispatch to different template based on selected dtd version. or even have 2 separate plugins, where one is hardwired to 2.0 and another to 3.0
Hide
Permalink
Anatol Pomozov added a comment -

It is Generama specific ticket.
I have already implement. See http://jira.codehaus.org/browse/XDOCLET-29.

Show
Anatol Pomozov added a comment - It is Generama specific ticket. I have already implement. See http://jira.codehaus.org/browse/XDOCLET-29 .

People

  • Assignee:
    Anatol Pomozov
    Reporter:
    Anatol Pomozov
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: