XDoclet 2 Plugins
  1. XDoclet 2 Plugins
  2. XDP-148

merge points don't work (for WebPlugin)

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: web
    • Labels:
      None
    • Number of attachments :
      0

      Description

      if i have a merge point file that doesn't have a root (like servlets.xml), then xdoclet fails because it is not a well formatted xml.

      however, if i add a dummy root element to it (as i have seen in the test application in the distribution), the root element is added to the resulting web.xml making it not valid.

      also, an annoyance is that when failing on a ill-formatted xml, the file name isn't given, even when run in debug mode (-X in maven). instead, it gives the line in WebPlugin.jelly, which means i have to unpack the jar and open this file, go to the line, in order to see which file of mine is to blame.

        Activity

        Hide
        Ittay Dror added a comment -

        wrapping the content in j:jelly solves this

        Show
        Ittay Dror added a comment - wrapping the content in j:jelly solves this
        Hide
        christophe yung added a comment -

        Hi,

        The same problem occurs with the StrutsPlugin.
        the <j:jelly> tag, or any other dummy tag seems to work well (as the tag is simply ignored).

        The single exception is with the struts-actions.xml merge file:
        -if you wrap content within tag, the tag then appears in the resulting strutsconfig.xml
        -if you don't wrap, you get an empty (0 bite) strutsconfig.

        i would gladly help fixin' it, but I don't know what to seek.

        Show
        christophe yung added a comment - Hi, The same problem occurs with the StrutsPlugin. the <j:jelly> tag, or any other dummy tag seems to work well (as the tag is simply ignored). The single exception is with the struts-actions.xml merge file: -if you wrap content within tag, the tag then appears in the resulting strutsconfig.xml -if you don't wrap, you get an empty (0 bite) strutsconfig. i would gladly help fixin' it, but I don't know what to seek.
        Hide
        Grégory Joseph added a comment -

        See XDP-154 and XDP-7 if you want to help resolve these issues.

        Show
        Grégory Joseph added a comment - See XDP-154 and XDP-7 if you want to help resolve these issues.
        Hide
        Konstantin Pribluda added a comment -

        Merge for jelly based plugins was reworked.
        (dedicated jelly tag )
        Contents of merge files shall be wrapped in:

        <j:jelly xmlns:j="jelly:core">

        ( and full jelly templating is also available there )

        Show
        Konstantin Pribluda added a comment - Merge for jelly based plugins was reworked. (dedicated jelly tag ) Contents of merge files shall be wrapped in: <j:jelly xmlns:j="jelly:core"> ( and full jelly templating is also available there )

          People

          • Assignee:
            Unassigned
            Reporter:
            Ittay Dror
          • Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: