Details

    • Type: New Feature New Feature
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.0.4
    • Component/s: None
    • Labels:
      None
    • Testcase included:
      yes
    • Number of attachments :
      2

      Description

      Hi

      Here is my JSF plugin I have tried to keep the directory structure the same as you.

      It is not really backward compatible with thet previous plugin, it was not always possible.

      There is one test case included I only ran it, using Eclipse. I didn't get it to run in maven. I spend a little time to figure it out but left it to you.
      You can probably see more easily what the problem is.

      Please contact me if you want more info or want additional patches (you probably will).

      I have made a list of Eclipse style TODO's in the code so if you use eclipse you can see what I thought was missing.

      1. FacesConfigPluginTest.java
        1 kB
        Karthik Guru

        Activity

        Hide
        Karthik Guru added a comment -

        Changed the testcase to work with Maven. Removed hardcoded reference to files with calls to getResourceRelativeToThisPackage.

        Show
        Karthik Guru added a comment - Changed the testcase to work with Maven. Removed hardcoded reference to files with calls to getResourceRelativeToThisPackage.
        Hide
        Grégory Joseph added a comment -

        Isn't anyone commenting on this? I have no clue about jsf, so I can't really do anything else than clean up the code a bit myself.
        (like removing useless javadoc or tabs...)

        Show
        Grégory Joseph added a comment - Isn't anyone commenting on this? I have no clue about jsf, so I can't really do anything else than clean up the code a bit myself. (like removing useless javadoc or tabs...)
        Hide
        Joris Wijlens added a comment -

        Is anything expected of me? I'm not very familiar with the process of contributing to this kind of projects. if so, right now I'm really busy but in the future (Januari) I will have some time to work on this.

        Show
        Joris Wijlens added a comment - Is anything expected of me? I'm not very familiar with the process of contributing to this kind of projects. if so, right now I'm really busy but in the future (Januari) I will have some time to work on this.
        Hide
        Grégory Joseph added a comment -

        Joris,
        I was just asking if any of the current commiter had comments / review on your plugin.
        I can't really say anything myself, as I'm totally ignorant about jsf.

        Show
        Grégory Joseph added a comment - Joris, I was just asking if any of the current commiter had comments / review on your plugin. I can't really say anything myself, as I'm totally ignorant about jsf.
        Hide
        Diogo Bacelar Quintela added a comment -

        Neither do I, however i am happy with commiting it.
        Anydev with any knowledge to give their word ?

        If not, we believe you Karthik

        Show
        Diogo Bacelar Quintela added a comment - Neither do I, however i am happy with commiting it. Anydev with any knowledge to give their word ? If not, we believe you Karthik
        Hide
        Diogo Bacelar Quintela added a comment -

        Sorry, it was Joris who contributed.

        Show
        Diogo Bacelar Quintela added a comment - Sorry, it was Joris who contributed.
        Hide
        Konstantin Pribluda added a comment -

        Sorry for the delay - somehow I overlooked it.
        NOw it is in 1.0.4-SNAPHOST on codehaus.

        Show
        Konstantin Pribluda added a comment - Sorry for the delay - somehow I overlooked it. NOw it is in 1.0.4-SNAPHOST on codehaus.

          People

          • Assignee:
            Konstantin Pribluda
            Reporter:
            Joris Wijlens
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: