XDoclet 2 Plugins

HibernateMappingPlugin.accumulateProperties property.setAccess("method")

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 1.0.4
  • Component/s: hibernate
  • Labels:
    None
  • Number of attachments :
    2

Description

In accumulateProperties(...)
if("field".equals(((DocletTag)getTags(beanProperties[i].getAccessor(),requieredTags).get(0)).getNamedParameter("access"))) {
property.setAccess("field");
} else {
//jh property.setAccess("method");
property.setAccess("property"); // my modification
}

Hibernate 3 failed on the generated hbm.xml containing:
access="method"

It should really be:
access="property"

  1. File
    plugin-hibernate-access.diff
    13/Nov/05 3:32 PM
    28 kB
    Rich Rodriguez
  2. Text File
    plugin-hibernate-access.patch
    13/Nov/05 3:48 PM
    29 kB
    Rich Rodriguez

Issue Links

is duplicated by

Bug - A problem which impairs or prevents the functions of the product. XDP-150 access="method" ???

  • Critical - Crashes, loss of data, severe memory leak.
  • Closed - The issue is considered finished, the resolution is correct. Issues which are not closed can be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Rich Rodriguez added a comment -

Per the docs at http://www.hibernate.org/hib_docs/v3/reference/en/html/mapping.html#mapping-declaration-property,

I've changed "method" to "property", and attached the patch for the plugin code and the tests.

Show
Rich Rodriguez added a comment - Per the docs at http://www.hibernate.org/hib_docs/v3/reference/en/html/mapping.html#mapping-declaration-property , I've changed "method" to "property", and attached the patch for the plugin code and the tests.
Hide
Permalink
Rich Rodriguez added a comment -

OK, a better patch that also takes care of the field mapping use of "method" I missed.

Show
Rich Rodriguez added a comment - OK, a better patch that also takes care of the field mapping use of "method" I missed.
Hide
Permalink
Davide Baroncelli added a comment -

Argh, I just got bitten by this one.

Show
Davide Baroncelli added a comment - Argh, I just got bitten by this one.
Hide
Permalink
Marc Guillemot added a comment -

I'm not sure but I think that the patch is wrong as well: if no access attribute is provided in the @hibernate.property tag (or others), then no access="..." should be generated as it is not a mandatory attribute.

This problem exists only since version 1.0.3 (this was ok in version 1.0.2)

Show
Marc Guillemot added a comment - I'm not sure but I think that the patch is wrong as well: if no access attribute is provided in the @hibernate.property tag (or others), then no access="..." should be generated as it is not a mandatory attribute. This problem exists only since version 1.0.3 (this was ok in version 1.0.2)
Hide
Permalink
Rich Rodriguez added a comment -

I believe omitting the attribute would be "more" correct. The patch does generate valid mapping files, just more verbose than is required.

Show
Rich Rodriguez added a comment - I believe omitting the attribute would be "more" correct. The patch does generate valid mapping files, just more verbose than is required.
Hide
Permalink
Joris Wijlens added a comment -

I agree with Rich, I never specify this attribute and go with the default of Hibernate.

I also suggest to set the priority of this issue to critical (maybe even do an extra release). Because I think everyone who uses Hibernate 3 will migrate back to 1.0.2 or has to use a snapshot.

Show
Joris Wijlens added a comment - I agree with Rich, I never specify this attribute and go with the default of Hibernate. I also suggest to set the priority of this issue to critical (maybe even do an extra release). Because I think everyone who uses Hibernate 3 will migrate back to 1.0.2 or has to use a snapshot.
Hide
Permalink
Konstantin Pribluda added a comment -

What about following behaviour:

1. If tag is on field, set it to field unless access is explicitely overriden
2. If tag is on method, omit this unless explicit setting is provided.

Show
Konstantin Pribluda added a comment - What about following behaviour: 1. If tag is on field, set it to field unless access is explicitely overriden 2. If tag is on method, omit this unless explicit setting is provided.
Hide
Permalink
Davide Baroncelli added a comment -

The behaviour Konstantin is envisioning seems reasonable to me, but I think what is most important is at least providing a release which is not broken with respect to Hibernate: it seems to me that it is pointless to leave a release out which fails in correctly supporting such an important feature. I remark that it is broken not only for Hibernate 3, but also for Hibernate 2 (and I'm not sure a snapshot would correct the problem, as no patch seems to have been applied to CVS).

Show
Davide Baroncelli added a comment - The behaviour Konstantin is envisioning seems reasonable to me, but I think what is most important is at least providing a release which is not broken with respect to Hibernate: it seems to me that it is pointless to leave a release out which fails in correctly supporting such an important feature. I remark that it is broken not only for Hibernate 3, but also for Hibernate 2 (and I'm not sure a snapshot would correct the problem, as no patch seems to have been applied to CVS).
Hide
Permalink
Konstantin Pribluda added a comment -

Fixed in CVS and deployed snapshot ( 1.0.4-SNAPSHOT )

Show
Konstantin Pribluda added a comment - Fixed in CVS and deployed snapshot ( 1.0.4-SNAPSHOT )
Hide
Permalink
Marvin Froeder added a comment -

Is possible to create a build of the hibernate plugin with this bug corrected?

I fond some dificulties to do that.

VELO

Show
Marvin Froeder added a comment - Is possible to create a build of the hibernate plugin with this bug corrected? I fond some dificulties to do that. VELO
Hide
Permalink
Konstantin Pribluda added a comment -

1.0.4-SNAPSHOT available from repo at distcodehaus.org has this
problem corrected.

Show
Konstantin Pribluda added a comment - 1.0.4-SNAPSHOT available from repo at distcodehaus.org has this problem corrected.
Hide
Permalink
Marvin Froeder added a comment -

Thanks! I have found after your tip.

If any more needs....
http://dist.codehaus.org/xdoclet-plugins/jars/xdoclet-plugin-hibernate-1.0.4-SNAPSHOT.jar

VELO

Show
Marvin Froeder added a comment - Thanks! I have found after your tip. If any more needs.... http://dist.codehaus.org/xdoclet-plugins/jars/xdoclet-plugin-hibernate-1.0.4-SNAPSHOT.jar VELO
Hide
Permalink
antony added a comment -

it suppose to be this is link is dead here http://dist.codehaus.org/xdoclet-plugins/jars/xdoclet-plugin-hibernate-1.0.4-SNAPSHOT.jar is dead. where i can find this snapshot please help it is very urgent.

thanks in advance

Alvin

Show
antony added a comment - it suppose to be this is link is dead here http://dist.codehaus.org/xdoclet-plugins/jars/xdoclet-plugin-hibernate-1.0.4-SNAPSHOT.jar is dead. where i can find this snapshot please help it is very urgent. thanks in advance Alvin
Hide
Permalink
Konstantin Pribluda added a comment -

Currently there is a problem on codehaus ( beaver & dist are in coma )

Snapshot you need may be available on ibiblio repository:
http://www.ibiblio.org/maven/xdoclet-plugins/jars/
( dated )

Or you may try to build it from source of sourceforge
http://www.sourceforge.net/projects/xdoclet-plugins

If this does not help, I may send it to you
( do not have your email, and do not like to send it via list )

Show
Konstantin Pribluda added a comment - Currently there is a problem on codehaus ( beaver & dist are in coma ) Snapshot you need may be available on ibiblio repository: http://www.ibiblio.org/maven/xdoclet-plugins/jars/ ( dated ) Or you may try to build it from source of sourceforge http://www.sourceforge.net/projects/xdoclet-plugins If this does not help, I may send it to you ( do not have your email, and do not like to send it via list )
Hide
Permalink
Andy Quinn added a comment -

Konstantin,

I am also looking for this snapshot. Can you help me?

Thanks,

Andy

Show
Andy Quinn added a comment - Konstantin, I am also looking for this snapshot. Can you help me? Thanks, Andy
Hide
Permalink
Konstantin Pribluda added a comment -

Scream about it on plugins interest mailing list
( I do not have your email )

Show
Konstantin Pribluda added a comment - Scream about it on plugins interest mailing list ( I do not have your email )

People

  • Assignee:
    Konstantin Pribluda
    Reporter:
    Jack Hung
Vote (4)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: