Latest XBean doesn't work with Spring 2.0 M2

I'm pretty sure this has to do with the fact the as of M2, Spring is compiled completely with Java 5. This doesn't mean that XBean needs to be, just that the bytecode signatures for functions may have changed and XBean just needs to be recompiled against it. Just a thought.

Could you compile XBean (I'm not a big maven savvy) with JDK 1.5 and Spring M2 and put a version on dist.codehaus.org?

It turns out this was a signature change by Spring and therefore this ticket can be closed out. They've reverted back to the original method signature which will be available again in 2.0M3.

http://opensource2.atlassian.com/projects/spring/browse/SPR-1677

I had run into the issue described above, so I downloaded Spring 2.0-M3 snapshot. I am getting a new compatability issue on the "registerBeanDefinitions" method signature. I looked in the source for this and there is no longer a BeanDefinitionReader parameter.

Stack Trace
==============================================================================================
2006-03-03 00:49:37,168 ERROR- [main] org.springframework.web.context.ContextLoader - Context initialization failed
org.springframework.beans.factory.BeanCreationException: Error creating bean with name 'broker' defined in ServletContext resource [/WEB-INF/applicationContext-jms.xml]: Invocation of init method failed; nested exception is java.lang.NoSuchMethodError: org.springframework.beans.factory.xml.DefaultXmlBeanDefinitionParser.registerBeanDefinitions(Lorg/springframework/beans/factory/support/BeanDefinitionReader;Lorg/w3c/dom/Document;Lorg/springframework/core/io/Resource;)I
java.lang.NoSuchMethodError: org.springframework.beans.factory.xml.DefaultXmlBeanDefinitionParser.registerBeanDefinitions(Lorg/springframework/beans/factory/support/BeanDefinitionReader;Lorg/w3c/dom/Document;Lorg/springframework/core/io/Resource;)I
at org.apache.xbean.spring.context.impl.XBeanXmlBeanDefinitionReader.registerBeanDefinitions(XBeanXmlBeanDefinitionReader.java:78)
at org.springframework.beans.factory.xml.XmlBeanDefinitionReader.doLoadBeanDefinitions(XmlBeanDefinitionReader.java:338)

The Spring ticket mentioned above has been closed and this is now an issue that needs to be fixed in order to be compatible with Spring 2.0.

this issue makes ActiveMQ incompatible with Spring 2.0M3 (e.g. embedded broker Spring bean becomes broken)

At first glance, this looks to be a tough change, but I think it's as simple as changing the registerBeanDefinitions() method in org.apache.xbean.spring.context.impl.XBeanXmlBeanDefinitionReader to look like this:

public int registerBeanDefinitions(Document doc, Resource resource) throws BeansException {
preprocess(doc);
XBeanXmlBeanDefinitionParser parser = new XBeanXmlBeanDefinitionParser();

ReaderContext readerContext = new ReaderContext(this, resource,
new FailFastProblemReporter(),
new XmlBeanDefinitionReader.NullReaderEventListener() ,
new NullSourceExtractor());

return parser.registerBeanDefinitions(doc, readerContext);
}

Of course, there are also a few imports that must be added to XBeanXmlBeanDefinitionReader to make the compiler happy:
import org.springframework.beans.factory.support.ReaderContext;
import org.springframework.beans.factory.xml.FailFastProblemResolver;
import org.springframework.beans.factory.support.NullSourceExtractor;

I'm behind a finicky firewall right now, or I'd create a patch and attach it here. If nobody beats me to it, I'll try to create a patch later this week (or this weekend) and attach it to this issue.

One gotcha with my fix in the previous comment: Changing XBean to use the new registerBeanDefinitions() method will have the unfortunate side-effect of making XBean incompatible with versions of Spring prior to 2.0-m3.

Thanks for the pointer Craig!

Unfortunately FailFastProblemReporter is not even visible

A modified file using Craig's patch

Craig: I've applied your patch and got it to compile (no idea if it'll work though). Unfortunately it looks like XBeanXmlBeanDefinitionParser will need a major rewrite to work with Spring 2.x as the base class looks to have been changed quite a lot