Woodstox

Flag collision in InputConfigFlags causing StAX non conformance

Details

  • Type: Bug Bug
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Fixed
  • Affects Version/s: 4.1.1
  • Fix Version/s: 4.1.3
  • Labels:
    None
  • Number of attachments :
    0

Description

InputConfigFlags defines two flags with the same value:

final static int CFG_AUTO_CLOSE_INPUT = 0x2000;
final static int CFG_NORMALIZE_LFS = 0x2000;

Since CFG_NORMALIZE_LFS is included in ReaderConfig.DEFAULT_FLAGS_FULL, this means that the input stream is closed when XMLStreamReader#close() is called. This is in contradiction with the StAX specification.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tatu Saloranta added a comment -

Very unfortunate. Will fix, assuming same is true for recently released 4.1.2?

Show
Tatu Saloranta added a comment - Very unfortunate. Will fix, assuming same is true for recently released 4.1.2?
Hide
Permalink
Andreas Veithen added a comment -

Yes. It affects 4.1.2 and also 4.0.x.

Show
Andreas Veithen added a comment - Yes. It affects 4.1.2 and also 4.0.x.
Hide
Permalink
Tatu Saloranta added a comment -

Ok, this is extremely unfortunate problem. I fixed it.

One question with 4.0 is that this change will change external behavior; and while correcting it, I'm not sure whether to release 4.0.11 with change or not.
With 4.1 it will be in 4.1.3, as it's just... right thing to do. Especially as there are no current plans for later versions (trunk is 5.0, requiring JDK 1.5, but there's no real demand for it right now).

Show
Tatu Saloranta added a comment - Ok, this is extremely unfortunate problem. I fixed it. One question with 4.0 is that this change will change external behavior; and while correcting it, I'm not sure whether to release 4.0.11 with change or not. With 4.1 it will be in 4.1.3, as it's just... right thing to do. Especially as there are no current plans for later versions (trunk is 5.0, requiring JDK 1.5, but there's no real demand for it right now).
Hide
Permalink
Andreas Veithen added a comment -

Thanks. Tested successfully with a 4.1.3 snapshot.

Show
Andreas Veithen added a comment - Thanks. Tested successfully with a 4.1.3 snapshot.
Hide
Permalink
Tatu Saloranta added a comment -

Was released in 4.1.3.

Show
Tatu Saloranta added a comment - Was released in 4.1.3.

People

  • Assignee:
    Tatu Saloranta
    Reporter:
    Andreas Veithen
Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: