Details
-
Type:
Improvement
-
Status:
In Progress
-
Priority:
Minor
-
Resolution: Unresolved
-
Affects Version/s: 4.1
-
Fix Version/s: None
-
Labels:None
-
Number of attachments :
Description
(by Murray Altheim on woodstox mailing list)
—
Summary: this suggests a simple patch so that the sourceFrom()
method in DefaultInputResolver can support InputSource objects.
I've been using Woodstox for about a month now and am currently
focused on using it for DTD and XSD analysis. I note that the DTD
flattening functionality of previous versions has now been wrapped
into the core (I'm using the 5.0 SNAPSHOT out of svn).
I immediately ran into a "bug" where the Object supplied as the last
parameter to the DefaultInputResolver.sourceFrom() method was the
result of resolving a DTD entity via Apache XML Commons'
resolver, i.e., a org.xml.sax.InputSource. In looking at the code for
the method I made a 30 second modification which provides easy
support for an InputSource (the SAX standard for entity sources). I'm
also not clear why (as a utility method) it couldn't be opened as a
public method; there are already developer warnings in the javadoc
about its suitable usage.
I am happy to supply a patch, either inline or as an attachment (not
sure what is the protocol around here).